Bug 86747

Summary:

[EFL] Fix link error caused by not directly linking with edbus

Product:

WebKit

Reporter:

Thiago Marcos P. Santos <tmpsantos>

Component:

WebKit EFL

Assignee:

Thiago Marcos P. Santos <tmpsantos>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, kihong.kwon, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Thiago Marcos P. Santos 2012-05-17 09:21:23 PDT

We are not specifying edbus as dependency but we are using it's symbols on BatteryClientEfl.cpp

../../../lib/libewebkit.so.0.1.0: error: undefined reference to 'e_dbus_bus_get'
../../../lib/libewebkit.so.0.1.0: error: undefined reference to 'dbus_error_is_set'
../../../lib/libewebkit.so.0.1.0: error: undefined reference to 'dbus_error_free'

It might work when not using the shared core build option because edbus is a dependency for eukit and the symbol is indirectly resolved.

Comment 1 Thiago Marcos P. Santos 2012-05-17 09:30:00 PDT

Created attachment 142488 [details]
Patch

Comment 2 WebKit Review Bot 2012-05-17 10:25:13 PDT

Comment on attachment 142488 [details]
Patch

Clearing flags on attachment: 142488

Committed r117459: <http://trac.webkit.org/changeset/117459>

Comment 3 WebKit Review Bot 2012-05-17 10:25:18 PDT

All reviewed patches have been landed.  Closing bug.