Use pixelSnappedLogicalHeight for TableSection layout

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Levi Weintraub]

Previously, we were using logicalHeight but storing the value as an int in RenderTableSection. We *want* to use ints, but we need to pixel snap the value.

[Levi Weintraub]

Created attachment 142329 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 142329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142329&action=review

> Source/WebCore/rendering/RenderBox.h:77
> +    int pixelSnappedLogicalHeight() const { return style()->isHorizontalWritingMode() ? pixelSnappedHeight() : pixelSnappedWidth(); }
> +    int pixelSnappedLogicalWidth() const { return style()->isHorizontalWritingMode() ? pixelSnappedWidth() : pixelSnappedHeight(); }

So sad that we have all these redundant accessors.  One would think that a logicalSize() might make more sense. :)

[Levi Weintraub]

Comment on attachment 142329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142329&action=review

>> Source/WebCore/rendering/RenderBox.h:77
>> +    int pixelSnappedLogicalWidth() const { return style()->isHorizontalWritingMode() ? pixelSnappedWidth() : pixelSnappedHeight(); }
> 
> So sad that we have all these redundant accessors.  One would think that a logicalSize() might make more sense. :)

Thanks for the review! I smell some potential cleanup :)

[WebKit Review Bot]

Comment on attachment 142329 [details]
Patch

Clearing flags on attachment: 142329

Committed r117388: <http://trac.webkit.org/changeset/117388>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.