Bug 86664

Summary: Make window-property-shadowing-name.html fail faster
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: New BugsAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, jianli, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Erik Arvidsson
Reported 2012-05-16 12:13:18 PDT
Make window-property-shadowing-name.html fail faster
Attachments
Patch (1.75 KB, patch)
2012-05-16 12:14 PDT, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Patch (1.97 KB, patch)
2012-05-16 12:34 PDT, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.89 KB, patch)
2012-05-16 13:10 PDT, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2012-05-16 12:14:50 PDT
Created attachment 142318 [details] Patch
Erik Arvidsson
Comment 2 2012-05-16 12:15:47 PDT
As discussed in bug 86389 we should not timeout when the tests fails.
Erik Arvidsson
Comment 3 2012-05-16 12:34:31 PDT
Created attachment 142325 [details] Patch
Ojan Vafai
Comment 4 2012-05-16 12:37:32 PDT
Comment on attachment 142325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142325&action=review Feel free to ignore the nits. > LayoutTests/fast/dom/Window/window-property-shadowing-name.html:16 > +var pass = finish.bind(null, "PASS"); > +var fail = finish.bind(null, "FAIL"); Nit: don't need these methods anymore, you can just call them inline below. > LayoutTests/fast/dom/Window/window-property-shadowing-name.html:24 > +var w = window.open("javascript:void 0", "test"); > +if (w === window) Nit: no need for the local variable.
Erik Arvidsson
Comment 5 2012-05-16 13:10:37 PDT
Created attachment 142328 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-05-16 14:57:18 PDT
Comment on attachment 142328 [details] Patch for landing Clearing flags on attachment: 142328 Committed r117349: <http://trac.webkit.org/changeset/117349>
WebKit Review Bot
Comment 7 2012-05-16 14:57:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.