Bug 86620 – [Qt] Web process hangs while waiting for plugin process connection during layouttests

• Component: Plug-ins
• Status: RESOLVED INVALID

[Balazs Kelemen]

Ancestor bug: https://bugs.webkit.org/show_bug.cgi?id=80691

During layout tests at some point the web process become blocked in PluginProcessConnectionManager::getPluginProcessConnection. This can happen with tests that actually don't use plugins most probably because of previous tests.

[Balazs Kelemen]

Created attachment 142251 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 142251 [details]
Patch

r=me

[Balazs Kelemen]

Comment on attachment 142251 [details]
Patch

Clearing flags on attachment: 142251

Committed r117288: <http://trac.webkit.org/changeset/117288>

[Balazs Kelemen]

All reviewed patches have been landed.  Closing bug.

[Balazs Kelemen]

Reopening, since this is not the final solution.

[Csaba Osztrogonác]

I had to skip zillion tests because disabling plugins:
http://trac.webkit.org/changeset/117401
http://trac.webkit.org/changeset/117405

plugins worked on Qt 4.8 before, but now it is disabled.
Shouldn't we disable it for Qt 5 only with a Qt version check?

[Balazs Kelemen]

Created attachment 142440 [details]
Patch

[Balazs Kelemen]

(In reply to comment #6)
> I had to skip zillion tests because disabling plugins:
> http://trac.webkit.org/changeset/117401
> http://trac.webkit.org/changeset/117405
> 
> plugins worked on Qt 4.8 before, but now it is disabled.
> Shouldn't we disable it for Qt 5 only with a Qt version check?

Yes, this is what we should do. Sorry for being hasty last time.

[Csaba Osztrogonác]

Comment on attachment 142440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142440&action=review

LGTM, with fixing the changelog. :)

> LayoutTests/ChangeLog:4
> +        Copy does not include displayed content sourced from an iFrame.
> +        https://bugs.webkit.org/show_bug.cgi?id=8662

[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620

[Balazs Kelemen]

I could not reproduce this locally now. I believe it has been fixed by Allan in http://trac.webkit.org/changeset/125024. I'm going to reenable plugin tests, filed bug 98528 for that task.

[Balazs Kelemen]

Comment on attachment 142440 [details]
Patch

Clearing flags.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.