Bug 86585

Summary: [Refactoring] Node::shadowHost() and Node::setShadowHost() can be moved to ShadowRoot
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Shinya Kawanaka
Reported 2012-05-16 00:25:13 PDT
Basically these methods are only for ShadowRoot. So we should be able to move them to ShadowRoot.
Attachments
Patch (20.25 KB, patch)
2012-05-16 20:02 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (24.42 KB, patch)
2012-05-17 21:25 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-05-16 20:02:38 PDT
Created attachment 142398 [details] Patch
Hajime Morrita
Comment 2 2012-05-17 01:03:20 PDT
Comment on attachment 142398 [details] Patch I think you can move setParent() to private as parent() is.
Shinya Kawanaka
Comment 3 2012-05-17 02:10:09 PDT
(In reply to comment #2) > (From update of attachment 142398 [details]) > I think you can move setParent() to private as parent() is. Unfortunately Attr::createTextChild touched it... If we want to make it private, it should be done by another patch I think...
Shinya Kawanaka
Comment 4 2012-05-17 02:12:28 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 142398 [details] [details]) > > I think you can move setParent() to private as parent() is. > > Unfortunately Attr::createTextChild touched it... > If we want to make it private, it should be done by another patch I think... Oh, let me discard this ...
Shinya Kawanaka
Comment 5 2012-05-17 21:25:12 PDT
Created attachment 142625 [details] Patch
WebKit Review Bot
Comment 6 2012-05-20 19:41:25 PDT
Comment on attachment 142625 [details] Patch Clearing flags on attachment: 142625 Committed r117723: <http://trac.webkit.org/changeset/117723>
WebKit Review Bot
Comment 7 2012-05-20 19:42:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.