Bug 86580

Summary: DFG should have sparse conditional constant propagation
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, ggaren, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
work in progress
none
more
none
the patch oliver: review+

Filip Pizlo
Reported 2012-05-16 00:03:25 PDT
Without it, we won't be able to make this loop evaporate, because the CFA will execute the "i++" basic block and pollute i. for (var i = 0; i < 1; ++i) doThings(i); Patch forthcoming, though I foresee this generating some bugs, so though the patch is simple it'll probably take a while to fully bake.
Attachments
work in progress (6.26 KB, patch)
2012-05-16 00:05 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more (18.95 KB, patch)
2012-05-16 12:48 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (20.31 KB, patch)
2012-05-16 14:28 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-05-16 00:05:44 PDT
Created attachment 142166 [details] work in progress
Filip Pizlo
Comment 2 2012-05-16 12:48:38 PDT
Created attachment 142326 [details] more
Filip Pizlo
Comment 3 2012-05-16 14:28:58 PDT
Created attachment 142346 [details] the patch Yup it works.
Filip Pizlo
Comment 4 2012-05-16 17:41:45 PDT
Landed in http://trac.webkit.org/changeset/117370
Filip Pizlo
Comment 5 2012-05-23 19:28:23 PDT
Merged in http://trac.webkit.org/changeset/118309
Note You need to log in before you can comment on or make changes to this bug.