Bug 8658

Summary:

Assertion failure in -[WebPluginContainerCheck _isForbiddenFileLoad] (bridge is null) when clicking QuickTime object with href

Product:

WebKit

Reporter:

mitz

Component:

Plug-ins

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar, Regression

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Test case	none
Set the plugin controller's data source (no test yet)	none
Patch, including manual test and change log	darin: review+
orange.mov for the manual test	none

mitz

Reported 2006-04-29 10:25:55 PDT

With a debug build of TOT, clicking the QuickTime object in the attached test case gives the following message: ASSERTION FAILED: bridge (WebKit/WebKit/Plugins/WebPluginContainerCheck.m:95 -[WebPluginContainerCheck _isForbiddenFileLoad]) The WebPluginController's dataSource is NULL.

Attachments
Test case (336 bytes, text/html) 2006-04-29 10:26 PDT, mitz	no flags	Details
Set the plugin controller's data source (no test yet) (438 bytes, patch) 2006-04-29 11:02 PDT, mitz	no flags	Details Formatted Diff Diff
Patch, including manual test and change log (3.47 KB, patch) 2006-04-29 12:34 PDT, mitz	darin: review+	Details Formatted Diff Diff
orange.mov for the manual test (875 bytes, video/quicktime) 2006-04-29 12:35 PDT, mitz	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2006-04-29 10:26:26 PDT

Created attachment 8032 [details] Test case

mitz

Comment 2 2006-04-29 11:02:21 PDT

Created attachment 8034 [details] Set the plugin controller's data source (no test yet)

mitz

Comment 3 2006-04-29 12:34:25 PDT

Created attachment 8036 [details] Patch, including manual test and change log I think the only way -[WebPluginContainerCheck _isForbiddenFileLoad] is reached is when a plugin calls a WebPlugInContainer private API, so the test has to use the QT plugin (which knows that API). I tried to make an automated test, but it had the side effect of opening QT Player on success.

mitz

Comment 4 2006-04-29 12:35:30 PDT

Created attachment 8037 [details] orange.mov for the manual test

Darin Adler

Comment 5 2006-04-29 20:41:39 PDT

Comment on attachment 8036 [details] Patch, including manual test and change log Looks right to me. r=me

Tim Omernick

Comment 6 2006-05-01 14:21:01 PDT

This is in Radar as <rdar://problem/4531779>. Fix landed to TOT, revision 14142.

Note You need to log in before you can comment on or make changes to this bug.