Bug 86566

Summary:

[V8] Pass Isolate to convertEventTargetToV8Object()

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84074

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2012-05-15 21:06:27 PDT

The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to convertEventTargetToV8Object().

Comment 1 Kentaro Hara 2012-05-15 21:20:55 PDT

Created attachment 142140 [details]
Patch

Comment 2 Nate Chapin 2012-05-16 08:33:30 PDT

Comment on attachment 142140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142140&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3830
> -        return "V8DOMWrapper::convertEventTargetToV8Object($value)";
> +        return "V8DOMWrapper::convertEventTargetToV8Object($value, $getIsolate)";

Does this need a bindings/scripts/test change?

Comment 3 Kentaro Hara 2012-05-16 17:17:53 PDT

Comment on attachment 142140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142140&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3830
>> +        return "V8DOMWrapper::convertEventTargetToV8Object($value, $getIsolate)";
> 
> Does this need a bindings/scripts/test change?

No change.

Comment 4 WebKit Review Bot 2012-05-16 18:18:48 PDT

Comment on attachment 142140 [details]
Patch

Clearing flags on attachment: 142140

Committed r117374: <http://trac.webkit.org/changeset/117374>

Comment 5 WebKit Review Bot 2012-05-16 18:18:52 PDT

All reviewed patches have been landed.  Closing bug.