Bug 86566

Summary: [V8] Pass Isolate to convertEventTargetToV8Object()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84074    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-05-15 21:06:27 PDT
The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to convertEventTargetToV8Object().
Attachments
Patch (3.93 KB, patch)
2012-05-15 21:20 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-15 21:20:55 PDT
Created attachment 142140 [details] Patch
Nate Chapin
Comment 2 2012-05-16 08:33:30 PDT
Comment on attachment 142140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142140&action=review > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3830 > - return "V8DOMWrapper::convertEventTargetToV8Object($value)"; > + return "V8DOMWrapper::convertEventTargetToV8Object($value, $getIsolate)"; Does this need a bindings/scripts/test change?
Kentaro Hara
Comment 3 2012-05-16 17:17:53 PDT
Comment on attachment 142140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142140&action=review >> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3830 >> + return "V8DOMWrapper::convertEventTargetToV8Object($value, $getIsolate)"; > > Does this need a bindings/scripts/test change? No change.
WebKit Review Bot
Comment 4 2012-05-16 18:18:48 PDT
Comment on attachment 142140 [details] Patch Clearing flags on attachment: 142140 Committed r117374: <http://trac.webkit.org/changeset/117374>
WebKit Review Bot
Comment 5 2012-05-16 18:18:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.