Bug 86561

Summary: RenderTableSection wastes vector capacity
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jchaffraix, kling, koivisto, robert, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 86281    
Attachments:
Description Flags
Proposed memory optimization. none

Simon Fraser (smfr)
Reported 2012-05-15 20:19:07 PDT
279 vectors, 87.19KB used of 174.38KB, 87.19KB wasted at: 1 0x1095d7c50 WTF::Vector<WebCore::RenderTableSection::CellStruct, 0ul>::Vector(WTF::Vector<WebCore::RenderTableSection::CellStruct, 0ul> const&) 2 0x1095d7a73 WTF::VectorMover<false, WebCore::RenderTableSection::RowStruct>::move(WebCore::RenderTableSection::RowStruct const*, WebCore::RenderTableSection::RowStruct const*, WebCore::RenderTableSection::RowStruct*) 3 0x1095d9878 WTF::Vector<WebCore::RenderTableSection::RowStruct, 0ul>::reserveCapacity(unsigned long) 4 0x1095d6892 WTF::Vector<WebCore::RenderTableSection::RowStruct, 0ul>::grow(unsigned long) 5 0x1095d1e05 WebCore::RenderTableSection::addChild(WebCore::RenderObject*, WebCore::RenderObject*) 152 vectors, 26.48KB used of 95.00KB, 68.52KB wasted at: 1 0x1095d68e8 WTF::Vector<WebCore::RenderTableSection::RowStruct, 0ul>::grow(unsigned long) 2 0x1095d1e05 WebCore::RenderTableSection::addChild(WebCore::RenderObject*, WebCore::RenderObject*) 3 0x1094898b9 WebCore::NodeRendererFactory::createRendererIfNeeded() 4 0x109480213 WebCore::Node::createRendererIfNeeded() 5 0x108f1ced7 WebCore::Element::attach()
Attachments
Proposed memory optimization. (2.02 KB, patch)
2012-06-18 07:46 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-05-15 20:21:35 PDT
Also 36 vectors, 20.20KB used of 40.45KB, 20.25KB wasted at: 1 0x1095d18a4 WebCore::RenderTableSection::RenderTableSection(WebCore::Node*) 2 0x10957b6b5 WebCore::RenderObject::createObject(WebCore::Node*, WebCore::RenderStyle*) 3 0x10948957c WebCore::NodeRendererFactory::createRenderer() 4 0x109489887 WebCore::NodeRendererFactory::createRendererIfNeeded() 5 0x109480213 WebCore::Node::createRendererIfNeeded()
Julien Chaffraix
Comment 2 2012-06-18 07:46:22 PDT
Created attachment 148099 [details] Proposed memory optimization.
WebKit Review Bot
Comment 3 2012-06-18 10:11:29 PDT
Comment on attachment 148099 [details] Proposed memory optimization. Clearing flags on attachment: 148099 Committed r120605: <http://trac.webkit.org/changeset/120605>
WebKit Review Bot
Comment 4 2012-06-18 10:11:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.