Bug 86550

Summary: GraphicsContext3D interface should not be aware of CanvasRenderingContext
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, enne, gns, kbr, philn, senorblanco, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
for EWS none

Description James Robinson 2012-05-15 17:20:12 PDT
GraphicsContext3D interface should not be aware of CanvasRenderingContext
Comment 1 James Robinson 2012-05-15 17:22:20 PDT
Created attachment 142103 [details]
Patch
Comment 2 Darin Adler 2012-05-15 17:28:29 PDT
Comment on attachment 142103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142103&action=review

> Source/WebCore/ChangeLog:16
> +        (WebCore):

Please don’t leave lines like this in the change log.

> Source/WebCore/ChangeLog:29
> +        (DrawingBuffer):

Ditto.
Comment 3 Early Warning System Bot 2012-05-15 17:32:44 PDT
Comment on attachment 142103 [details]
Patch

Attachment 142103 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12717024
Comment 4 James Robinson 2012-05-15 17:35:19 PDT
Comment on attachment 142103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142103&action=review

>> Source/WebCore/ChangeLog:16
>> +        (WebCore):
> 
> Please don’t leave lines like this in the change log.

Thanks for the very quick review.  This line came from the prepare-ChangeLogs script, so should we instead modify the script to not leave these lines instead of asking patch authors to remove it by hand?
Comment 5 Early Warning System Bot 2012-05-15 18:06:48 PDT
Comment on attachment 142103 [details]
Patch

Attachment 142103 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12709252
Comment 6 Build Bot 2012-05-15 18:18:18 PDT
Comment on attachment 142103 [details]
Patch

Attachment 142103 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12701651
Comment 7 James Robinson 2012-05-15 19:04:52 PDT
Created attachment 142126 [details]
for EWS
Comment 8 James Robinson 2012-05-16 19:17:58 PDT
Comment on attachment 142126 [details]
for EWS

Clearing flags on attachment: 142126

Committed r117379: <http://trac.webkit.org/changeset/117379>
Comment 9 James Robinson 2012-05-16 19:18:04 PDT
All reviewed patches have been landed.  Closing bug.