Summary: | GraphicsContext3D interface should not be aware of CanvasRenderingContext | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||
Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, cc-bugs, enne, gustavo, kbr, philn, senorblanco, webkit.review.bot, xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
James Robinson
2012-05-15 17:20:12 PDT
Created attachment 142103 [details]
Patch
Comment on attachment 142103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142103&action=review > Source/WebCore/ChangeLog:16 > + (WebCore): Please don’t leave lines like this in the change log. > Source/WebCore/ChangeLog:29 > + (DrawingBuffer): Ditto. Comment on attachment 142103 [details] Patch Attachment 142103 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12717024 Comment on attachment 142103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142103&action=review >> Source/WebCore/ChangeLog:16 >> + (WebCore): > > Please don’t leave lines like this in the change log. Thanks for the very quick review. This line came from the prepare-ChangeLogs script, so should we instead modify the script to not leave these lines instead of asking patch authors to remove it by hand? Comment on attachment 142103 [details] Patch Attachment 142103 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12709252 Comment on attachment 142103 [details] Patch Attachment 142103 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12701651 Created attachment 142126 [details]
for EWS
Comment on attachment 142126 [details] for EWS Clearing flags on attachment: 142126 Committed r117379: <http://trac.webkit.org/changeset/117379> All reviewed patches have been landed. Closing bug. |