Bug 86550

Summary: GraphicsContext3D interface should not be aware of CanvasRenderingContext
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, enne, gustavo, kbr, philn, senorblanco, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
for EWS none

James Robinson
Reported 2012-05-15 17:20:12 PDT
GraphicsContext3D interface should not be aware of CanvasRenderingContext
Attachments
Patch (16.67 KB, patch)
2012-05-15 17:22 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
for EWS (16.66 KB, patch)
2012-05-15 19:04 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-05-15 17:22:20 PDT
Created attachment 142103 [details] Patch
Darin Adler
Comment 2 2012-05-15 17:28:29 PDT
Comment on attachment 142103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142103&action=review > Source/WebCore/ChangeLog:16 > + (WebCore): Please don’t leave lines like this in the change log. > Source/WebCore/ChangeLog:29 > + (DrawingBuffer): Ditto.
Early Warning System Bot
Comment 3 2012-05-15 17:32:44 PDT
Comment on attachment 142103 [details] Patch Attachment 142103 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12717024
James Robinson
Comment 4 2012-05-15 17:35:19 PDT
Comment on attachment 142103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142103&action=review >> Source/WebCore/ChangeLog:16 >> + (WebCore): > > Please don’t leave lines like this in the change log. Thanks for the very quick review. This line came from the prepare-ChangeLogs script, so should we instead modify the script to not leave these lines instead of asking patch authors to remove it by hand?
Early Warning System Bot
Comment 5 2012-05-15 18:06:48 PDT
Comment on attachment 142103 [details] Patch Attachment 142103 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12709252
Build Bot
Comment 6 2012-05-15 18:18:18 PDT
Comment on attachment 142103 [details] Patch Attachment 142103 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12701651
James Robinson
Comment 7 2012-05-15 19:04:52 PDT
Created attachment 142126 [details] for EWS
James Robinson
Comment 8 2012-05-16 19:17:58 PDT
Comment on attachment 142126 [details] for EWS Clearing flags on attachment: 142126 Committed r117379: <http://trac.webkit.org/changeset/117379>
James Robinson
Comment 9 2012-05-16 19:18:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.