Summary: | Incorporate Mozilla's improved texture format conversion code | ||
---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> |
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | bfulgham, gman, jamesr, jbauman, kalyan.kondapally, kkinnunen, senorblanco, zmo |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | 66884, 85942 | ||
Bug Blocks: |
Description
Kenneth Russell
2012-05-15 13:06:58 PDT
When incorporating this code, care needs to be taken to not lose the optimizations John Bauman added in Bug 66884, associated Chromium bug http://crbug.com/92388 . He indicated offline that he tested with http://jsperf.com/webgl-teximage2d-vs-texsubimage2d/2 (and possibly other versions of the test) as well as webgl-ios-rage. He also indicates: "part of my fix should become redundant due to the fact that they're never copying to an intermediate buffer, and you should be able to modify unpack<BGRA8, uint8_t, uint8_t> to use the faster BGRA->RGBA conversion". Better to work through the cases based on a benchmark than import new coed |