Bug 86489

Summary: [Qt] plugin is loaded to the web process via MainResourceLoader::substituteMIMETypeFromPluginDatabase
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Plug-insAssignee: Balazs Kelemen <kbalazs>
Status: RESOLVED FIXED    
Severity: Normal CC: japhet, jochen, kenneth, webkit.review.bot, yael
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Balazs Kelemen
Reported 2012-05-15 09:00:21 PDT
We should not load plugins to the web process, especially not via the wk1 plugin code path.
Attachments
Patch (3.00 KB, patch)
2012-06-06 10:02 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2012-05-17 02:03:43 PDT
This code has been added in https://bugs.webkit.org/show_bug.cgi?id=32572. It's possible to reimplement it in a way that fits with WebKit2 by going trough PluginData -> WebPlatformStrategies -> UI process but I have trouble with testing this functionality. I could not load an swf file with QtTestBrowser on unpatched trunk - actually I found an swf file that loads but it doesn't show anything else than black. Do you think it should work on trunk? Could you give an example I can test with? Or maybe we should just drop that?
Balazs Kelemen
Comment 2 2012-06-06 10:02:51 PDT
Created attachment 146053 [details] Patch
Simon Hausmann
Comment 3 2012-06-27 22:31:51 PDT
Comment on attachment 146053 [details] Patch I very much agree with this, the symptom (webprocess shouldn't load plugins through wk1 code path by use of PluginDatabase) as well as the removal of this hack :)
Balazs Kelemen
Comment 4 2012-06-28 02:36:12 PDT
Comment on attachment 146053 [details] Patch Clearing flags on attachment: 146053 Committed r121423: <http://trac.webkit.org/changeset/121423>
Balazs Kelemen
Comment 5 2012-06-28 02:36:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.