| Summary: | Pass Attribute by const reference as much as possible. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||
| Component: | DOM | Assignee: | Andreas Kling <kling> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, eric.carlson, feature-media-reviews, haraken, japhet, tkent, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andreas Kling
2012-05-15 08:19:39 PDT
Created attachment 141973 [details]
Patch
Comment on attachment 141973 [details]
Patch
r=me, but you should re-base your patch so the EWS can try it out for you
Created attachment 142004 [details]
Patch, reup for EWS
Attachment 142004 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/svg/SVGFitToViewBox.cpp:93: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/html/HTMLFrameSetElement.cpp:97: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/html/HTMLAppletElement.cpp:52: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/html/HTMLAppletElement.cpp:53: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/html/HTMLAppletElement.cpp:54: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/html/HTMLAppletElement.cpp:55: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/html/HTMLAppletElement.cpp:56: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/html/HTMLElement.cpp:238: An else should appear on the same line as the preceding } [whitespace/newline] [4]
Total errors found: 8 in 257 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 142004 [details] Patch, reup for EWS Attachment 142004 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12683824 Created attachment 142032 [details]
Patch, cr-ews fix
Attachment 142032 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/html/HTMLFrameSetElement.cpp:97: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/html/HTMLElement.cpp:238: An else should appear on the same line as the preceding } [whitespace/newline] [4]
Total errors found: 2 in 257 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r117195: <http://trac.webkit.org/changeset/117195> |