Bug 86473

Summary:

[EFL] [DRT] Unskip passing tests related to computedStyleIncludingVisitedInfo and display

Product:

WebKit

Reporter:

Sudarsana Nagineni (babu) <naginenis>

Component:

WebKit EFL

Assignee:

Sudarsana Nagineni (babu) <naginenis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Sudarsana Nagineni (babu)

Reported 2012-05-15 06:01:16 PDT

The following tests are not failing anymore on EFL port. I am going to unksip them. -# computedStyleIncludingVisitedInfo is not implemented -# https://bugs.webkit.org/show_bug.cgi?id=37336 -fast/history/nested-visited-test.html -fast/history/self-is-visited.html -fast/history/sibling-visited-test.html -fast/history/multiple-classes-visited.html -fast/loader/stateobjects/state-url-sets-links-visited.html -# BUG: Needs a grayish canvas background. See DumpRenderTree/chromium/WebViewHost::displayRepaintMask(). -fast/repaint/absolute-position-change-containing-block.html -fast/repaint/absolute-position-moved.html -fast/repaint/fixed-to-relative-position-with-absolute-child.html -fast/repaint/inline-overflow.html -fast/repaint/inline-relative-positioned.html -fast/repaint/overflow-flipped-writing-mode-block.html -fast/repaint/overflow-flipped-writing-mode-table.html -fast/repaint/text-in-relative-positioned-inline.html -fast/repaint/trailing-floats-root-line-box-overflow.html -fast/table/simple_paint.html -fast/table/border-collapsing/cached-cell-append.html -fast/table/border-collapsing/cached-cell-remove.html -fast/table/border-collapsing/cached-change-cell-border-color.html -fast/table/border-collapsing/cached-change-cell-border-width.html -fast/table/border-collapsing/cached-change-cell-sl-border-color.html -fast/table/border-collapsing/cached-change-col-border-color.html -fast/table/border-collapsing/cached-change-col-border-width.html -fast/table/border-collapsing/cached-change-colgroup-border-color.html -fast/table/border-collapsing/cached-change-colgroup-border-width.html -fast/table/border-collapsing/cached-change-row-border-color.html -fast/table/border-collapsing/cached-change-row-border-width.html -fast/table/border-collapsing/cached-change-table-border-color.html -fast/table/border-collapsing/cached-change-table-border-width.html -fast/table/border-collapsing/cached-change-tbody-border-color.html -fast/table/border-collapsing/cached-change-tbody-border-width.html

Attachments
Patch (3.31 KB, patch) 2012-05-15 06:05 PDT, Sudarsana Nagineni (babu)	no flags	Details Formatted Diff Diff
Patch (2.65 KB, patch) 2012-05-16 02:48 PDT, Sudarsana Nagineni (babu)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sudarsana Nagineni (babu)

Comment 1 2012-05-15 06:05:34 PDT

Created attachment 141941 [details] Patch Unskip passing tests

WebKit Review Bot

Comment 2 2012-05-15 08:37:45 PDT

Comment on attachment 141941 [details] Patch Clearing flags on attachment: 141941 Committed r117073: <http://trac.webkit.org/changeset/117073>

WebKit Review Bot

Comment 3 2012-05-15 08:37:50 PDT

All reviewed patches have been landed. Closing bug.

Sudarsana Nagineni (babu)

Comment 4 2012-05-16 02:46:26 PDT

Reopening the bug since the tests related to repaint are failing with unexpected image mismatch.

Sudarsana Nagineni (babu)

Comment 5 2012-05-16 02:48:53 PDT

Created attachment 142208 [details] Patch Partially reverts r117073. Sorry about mix up.

Gyuyoung Kim

Comment 6 2012-05-16 03:01:36 PDT

Comment on attachment 142208 [details] Patch Personally, I don't like to re-open bugs. But, in this case, to revert r117073 influences on these test cases. So, I set cq+ again.

WebKit Review Bot

Comment 7 2012-05-16 04:57:16 PDT

Comment on attachment 142208 [details] Patch Clearing flags on attachment: 142208 Committed r117264: <http://trac.webkit.org/changeset/117264>

WebKit Review Bot

Comment 8 2012-05-16 04:57:22 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.