Bug 86450 – showNodePath will be useful for debugging purpose.

• Component: DOM
• Status: RESOLVED FIXED

[Shinya Kawanaka]

showTree(node) is useful, but it often outputs too much.
For printf-style debugging, it would be useful to have much less information.
For example, showNodePath which outputs something like an XPath will be useful.

[Shinya Kawanaka]

Maybe tasak@ will work for this.

[Takashi Sakamoto]

Created attachment 141913 [details]
Patch

[Shinya Kawanaka]

Comment on attachment 141913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141913&action=review

> Source/WebCore/dom/Node.cpp:2242
> +            fprintf(stderr, "/#shadow-root");

Maybe you can continue here?

> Source/WebCore/dom/Node.cpp:2247
> +            CString idname;

Where is this used?

[Takashi Sakamoto]

Created attachment 142127 [details]
Patch

[Takashi Sakamoto]

(In reply to comment #3)
> (From update of attachment 141913 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141913&action=review
> 
> > Source/WebCore/dom/Node.cpp:2242
> > +            fprintf(stderr, "/#shadow-root");
> 
> Maybe you can continue here?

Yes. Done.

> 
> > Source/WebCore/dom/Node.cpp:2247
> > +            CString idname;
> 
> Where is this used?

I removed.

[Hajime Morrita]

Comment on attachment 142127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=142127&action=review

Please take care of of ShadowRoot, please...

> Source/WebCore/dom/Node.cpp:2234
> +    while (index) {

Let's loop with for() if there is no specific reason.

[Takashi Sakamoto]

Created attachment 142163 [details]
Patch

[Takashi Sakamoto]

Created attachment 142430 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 142430 [details]
Patch for landing

Clearing flags on attachment: 142430

Committed r117417: <http://trac.webkit.org/changeset/117417>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.