Bug 86447

Summary: [BlackBerry] Enhance an API of BackingStore::drawContents
Product: WebKit Reporter: Chris.Guan <logingx>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: manyoso, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris.Guan
Reported 2012-05-14 23:43:12 PDT
Enhance the current APIs by adding parameters of id and destination contentSize, Because chrome browser may want different contents from the same webview at different times.
Attachments
Patch (5.74 KB, patch)
2012-05-15 00:14 PDT, Chris.Guan 		no flags
DetailsFormatted DiffDiff
Patch (5.73 KB, patch)
2012-05-15 21:18 PDT, Chris.Guan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris.Guan
Comment 1 2012-05-15 00:14:43 PDT
Created attachment 141873 [details] Patch
Antonio Gomes
Comment 2 2012-05-15 07:22:51 PDT
Comment on attachment 141873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141873&action=review Maybe Adam could review it, but there are some nitpicks to get fixed before landing. > Source/WebKit/blackberry/Api/BackingStore.cpp:2219 > + const BlackBerry::Platform::IntRect& contentsRect, > + const BlackBerry::Platform::IntSize& destinationSize) const BlackBerry:: is unneeded here. > Source/WebKit/blackberry/Api/BackingStore.cpp:2842 > +void BackingStore::drawContents(BlackBerry::Platform::Graphics::Drawable* drawable, const BlackBerry::Platform::IntRect& contentsRect, const BlackBerry::Platform::IntSize& destinationSize) Ditto.
Chris.Guan
Comment 3 2012-05-15 21:18:45 PDT
Created attachment 142138 [details] Patch
WebKit Review Bot
Comment 4 2012-05-15 23:44:05 PDT
Comment on attachment 142138 [details] Patch Clearing flags on attachment: 142138 Committed r117223: <http://trac.webkit.org/changeset/117223>
WebKit Review Bot
Comment 5 2012-05-15 23:44:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.