Bug 86447

Summary: [BlackBerry] Enhance an API of BackingStore::drawContents
Product: WebKit Reporter: Chris.Guan <logingx>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: manyoso, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris.Guan 2012-05-14 23:43:12 PDT 
Enhance the current APIs by adding parameters of id and destination contentSize, Because chrome browser may want different contents from the same webview at different times.
Comment 1 Chris.Guan 2012-05-15 00:14:43 PDT 
Created attachment 141873 [details]
Patch
Comment 2 Antonio Gomes 2012-05-15 07:22:51 PDT 
Comment on attachment 141873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141873&action=review

Maybe Adam could review it, but there are some nitpicks to get fixed before landing.

> Source/WebKit/blackberry/Api/BackingStore.cpp:2219
> +                                         const BlackBerry::Platform::IntRect& contentsRect,
> +                                         const BlackBerry::Platform::IntSize& destinationSize) const

BlackBerry:: is unneeded here.

> Source/WebKit/blackberry/Api/BackingStore.cpp:2842
> +void BackingStore::drawContents(BlackBerry::Platform::Graphics::Drawable* drawable, const BlackBerry::Platform::IntRect& contentsRect, const BlackBerry::Platform::IntSize& destinationSize)

Ditto.
Comment 3 Chris.Guan 2012-05-15 21:18:45 PDT 
Created attachment 142138 [details]
Patch
Comment 4 WebKit Review Bot 2012-05-15 23:44:05 PDT 
Comment on attachment 142138 [details]
Patch

Clearing flags on attachment: 142138

Committed r117223: <http://trac.webkit.org/changeset/117223>
Comment 5 WebKit Review Bot 2012-05-15 23:44:09 PDT 
All reviewed patches have been landed.  Closing bug.