Bug 86395

Summary: The "plug-in was blocked" callback needs to include enough info to uniquely identify the plug-in + version
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sullivan: review+

Anders Carlsson
Reported 2012-05-14 13:37:25 PDT
The "plug-in was blocked" callback needs to include enough info to uniquely identify the plug-in + version
Attachments
Patch (5.41 KB, patch)
2012-05-14 13:38 PDT, Anders Carlsson 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-05-14 13:38:25 PDT
Created attachment 141777 [details] Patch
John Sullivan
Comment 2 2012-05-14 13:44:28 PDT
Comment on attachment 141777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141777&action=review > Source/WebKit2/UIProcess/WebLoaderClient.cpp:275 > + m_client.pluginDidFail(toAPI(page), kWKErrorCodeCannotLoadPlugIn, toAPI(mimeType.impl()), 0, 0, m_client.clientInfo); It would be good to explain in the ChangeLog why we don't pass the new parameters here.
Anders Carlsson
Comment 3 2012-05-14 13:49:05 PDT
Committed r116993: <http://trac.webkit.org/changeset/116993>
Note You need to log in before you can comment on or make changes to this bug.