Bug 86375

Summary: Web Inspector: Add keyboard shortcut for closing tab on scripts panel.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED INVALID    
Severity: Normal CC: apavlov, bburg, bweinstein, joepeck, keishi, lmjabreu, loislo, pfeldman, pmuellr, rik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review-

Vsevolod Vlasov
Reported 2012-05-14 08:19:59 PDT
Patch to follow.
Attachments
Patch (4.19 KB, patch)
2012-05-14 08:26 PDT, Vsevolod Vlasov 		pfeldman: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-05-14 08:26:56 PDT
Created attachment 141735 [details] Patch
Pavel Feldman
Comment 2 2012-05-14 08:34:48 PDT
Comment on attachment 141735 [details] Patch I don't think we need a shortcut for this. Could you park this bug for now?
Luis Abreu
Comment 3 2012-12-27 03:21:04 PST
Pavel, can you share your reasoning? My reasoning is that by offering shortcuts for many other features of the web inspector: opening files, switching between tabs, controlling execution, etc. For reasons of consistency, it would also make sense to allow the currently focused file source (tab) to be closed. On an unrelated note, it seems the web inspector shorcuts weren't properly sandboxed, sometimes, as it is with the case of jump to line, an already-existing keyboard shortcut is remapped based on context, and there's no relation between contexts.
Pavel Feldman
Comment 4 2012-12-27 04:18:13 PST
I think that it should either be a standard shortcut (Ctrl/Cmd+W) or nothing. But we can't make it Ctrl+W. So in this case, I would argue that the functionality is not valuable enough to bring in yet another confusion such as the one you refer to (jump to line).
Note You need to log in before you can comment on or make changes to this bug.