Bug 86319 – Unify RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp

• Component: MathML
• Status: RESOLVED FIXED

[Dave Barton]

Unify RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp

[Dave Barton]

Created attachment 141606 [details]
Patch

[Darin Adler]

Comment on attachment 141606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141606&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore):

Please remove bogus lines like this from the ChangeLog, or you could fix the prepare-ChangeLog script to not emit those.

> Source/WebCore/ChangeLog:19
> +        (WebCore):

Ditto.

> Source/WebCore/ChangeLog:22
> +        (WebCore):

Ditto.

> Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:91
> +    int frontWidth = static_cast<int>(roundf(gFrontWidthEms * style()->fontSize()));

It seems strange to call static_cast<int>(roundf()) since lroundf does the same thing without a cast.

> Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:111
> +        int partDipHeight = static_cast<int>(roundf((1 - gRootRadicalDipLeftPointYPos) * baseHeight));

Ditto.

> Source/WebCore/rendering/mathml/RenderMathMLRoot.h:41
> +    virtual void computePreferredLogicalWidths() OVERRIDE;

Why protected rather than private?

[Dave Barton]

Created attachment 141644 [details]
Patch

[Dave Barton]

Thanks for the review+, Darin. I made just the changes you suggested, but my committer paperwork hasn't gone through yet, so I still need a cq+ from someone. Thanks!

[Levi Weintraub]

(In reply to comment #4)
> Thanks for the review+, Darin. I made just the changes you suggested, but my committer paperwork hasn't gone through yet, so I still need a cq+ from someone. Thanks!

I've put you into the commit queue. This was one of the bits of MathML rendering that bugged me the most. Thanks for cleaning it up!

[WebKit Review Bot]

Comment on attachment 141644 [details]
Patch

Rejecting attachment 141644 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12694256

[Levi Weintraub]

(In reply to comment #6)
> (From update of attachment 141644 [details])
> Rejecting attachment 141644 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1
> 
> ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
> 
> Full output: http://queues.webkit.org/results/12694256

The ChangeLog needs to be updated with Darin as the reviewer. I can take care of that for you if you'd like.

[Dave Barton]

> The ChangeLog needs to be updated with Darin as the reviewer. I can take care of that for you if you'd like.

That would be wonderful. I meant to do that before creating the new patch and forgot (I am still new and learning). Thanks very much for the commit and the help!!

[Levi Weintraub]

Created attachment 141750 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 141750 [details]
Patch for landing

Clearing flags on attachment: 141750

Committed r116975: <http://trac.webkit.org/changeset/116975>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.