Bug 86289

Summary: [CSSRegions]Convert render-region-custom-style-mark to ref test
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Mihnea Ovidenie
Reported 2012-05-12 03:43:12 PDT
This test from fast/regions was the first region style test added, before region styling was implemented. It was meant to check that a region with custom region styling rules is marked properly in DRT. Since background color now works in region styling, this test can be converted to a ref test.
Attachments
Patch (100.05 KB, patch)
2012-05-12 03:51 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (100.70 KB, patch)
2012-05-14 08:25 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2012-05-12 03:51:47 PDT
Created attachment 141568 [details] Patch
WebKit Review Bot
Comment 2 2012-05-12 03:55:31 PDT
Attachment 141568 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 LayoutTests/ChangeLog:9: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] LayoutTests/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] LayoutTests/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2012-05-14 07:59:05 PDT
Comment on attachment 141568 [details] Patch rs=me with style whine fixed.
Mihnea Ovidenie
Comment 4 2012-05-14 08:25:48 PDT
Created attachment 141734 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-05-14 09:05:58 PDT
Comment on attachment 141734 [details] Patch for landing Clearing flags on attachment: 141734 Committed r116955: <http://trac.webkit.org/changeset/116955>
WebKit Review Bot
Comment 6 2012-05-14 09:06:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.