Bug 86265 – REGRESSION(r104885): Images missing from printed YummySoup! recipes

• Component: WebKit API
• Status: RESOLVED FIXED

[Brady Eidson]

REGRESSION(r104885): Images missing from printed YummySoup! recipes

We know we suspected we might break certain apps in http://trac.webkit.org/changeset/104885

One of those was fixed in http://trac.webkit.org/changeset/107355 where we assumed we were seeing "Paths-as-URLs" passed in at the API layer.

In exploring YummySoup! we found that these bogus URLs were more likely to be "file URLs with file: stripped off the beginning"

107355 didn't *quite* handle this properly, so a different fix is forthcoming.

In radar as <rdar://problem/11361907>

[Brady Eidson]

Created attachment 141518 [details]
Patch v1

[Alexey Proskuryakov]

Comment on attachment 141518 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=141518&action=review

> Source/WebKit/mac/ChangeLog:12
> +        Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrMalformedFileURL, and change it

"Malformed" may sound like too much of a real thing, perhaps "Legacy" would be better?

[Brady Eidson]

(In reply to comment #2)
> (From update of attachment 141518 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141518&action=review
> 
> > Source/WebKit/mac/ChangeLog:12
> > +        Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrMalformedFileURL, and change it
> 
> "Malformed" may sound like too much of a real thing, perhaps "Legacy" would be better?

"LegacyFileURL" implies it was ever a valid file URL.

I chose "Malformed" to stress its invalidity.

I'll go with "Invalid".

[Alexey Proskuryakov]

A schemeless URL like this is still a valid relative URL AFAICT, and it points to a different file system object that may or may not exist. "Legacy URL" is also somewhat misleading, but it should communicate that part at least.

[Brady Eidson]

Alexey and I discussed more on IRC and agreed on "Schemeless"

[Brady Eidson]

http://trac.webkit.org/changeset/116820