Bug 86203
| Summary: | REGRESSION (r116659?): Assertion failures in JSC marking | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> |
| Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fpizlo, ggaren, gustavo, mhahnenberg, msaboff |
| Priority: | P1 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Antti Koivisto
It looks like we started getting lots of marking related crashes after r116659.
http://build.webkit.org/results/Lion%20Debug%20(Tests)/r116675%20(6428)/sputnik/Unicode/Unicode_510/S7.6_A3.1-crash-log.txt
http://build.webkit.org/results/Lion%20Debug%20(Tests)/r116675%20(6428)/inspector/debugger/script-formatter-console-crash-log.txt
http://build.webkit.org/results/Lion%20Debug%20(Tests)/r116677%20(6430)/inspector/styles/show-user-agent-styles-crash-log.txt
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Geoffrey Garen
Seems like the best thing here is to roll out the patch and rework it. I'd suggest returning to the model where all strings are hash-const'd, to make bugs less elusive.
Michael Saboff
Rolled out r116659: <http://trac.webkit.org/changeset/116659> in r116822 <http://trac.webkit.org/changeset/116822>.