Bug 86173

Summary: Web Inspector: [JSC] instrument timer function calls
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, kpiascik, loislo, pfeldman, pmuellr, rik, sam, timothy, webkit.review.bot, yurys
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Change
yurys: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03
none
Proposed Change (Updated Test Results) pfeldman: review+, timothy: commit-queue-

Description Timothy Hatcher 2012-05-10 21:27:04 PDT
ScheduledAction::executeFunctionInContext does not instrument the function call, so timer's don't show the url/line number in the Timeline.
Comment 1 Timothy Hatcher 2012-05-10 21:27:20 PDT
<rdar://problem/11427463>
Comment 2 Timothy Hatcher 2012-05-10 21:33:08 PDT
Created attachment 141322 [details]
Proposed Change
Comment 3 WebKit Review Bot 2012-05-11 01:43:09 PDT
Comment on attachment 141322 [details]
Proposed Change

Attachment 141322 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12671283

New failing tests:
inspector/timeline/timeline-script-tag-1.html
inspector/timeline/timeline-timer.html
inspector/timeline/timeline-script-tag-2.html
inspector/timeline/timeline-injected-script-eval.html
Comment 4 WebKit Review Bot 2012-05-11 01:43:15 PDT
Created attachment 141354 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Timothy Hatcher 2012-05-11 09:48:41 PDT
Created attachment 141436 [details]
Proposed Change (Updated Test Results)
Comment 6 Konrad Piascik 2012-06-08 08:50:30 PDT
This has laneded with http://trac.webkit.org/changeset/116821