Summary: | REGRESSION: TinyMCE: Crash on Undo | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Justin Garcia <justin.garcia> | ||||
Component: | HTML Editing | Assignee: | Justin Garcia <justin.garcia> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alice.barraclough, c.petersen87, darin, troyb | ||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
URL: | http://tinymce.moxiecode.com/example.php?example=true | ||||||
Attachments: |
|
Description
Justin Garcia
2006-04-26 16:35:27 PDT
We think we could have one SC per page, instead of one per frame. That would help. (In reply to comment #1) > We think we could have one SC per page, instead of one per frame. That would > help. That sounds good. But there may be some circumstances where we want to support a selection in more than one frame. For example, there can be an active selection in an active frame and an inactive selection in an inactive frame. In general, Safari uses WebView in the "one selection in entire window" mode, but Mail, for example, uses WebView in the "one active selection and one or more inactive selections in a window" mode. Because of the Mail use case, I'm not sure we need to support multiple selections in a tree, but I'm not absolute sure we don't, assuming you were using a web page to implement the Mail application with a design mode frame as the document. *** Bug 8807 has been marked as a duplicate of this bug. *** *** Bug 7151 has been marked as a duplicate of this bug. *** I believe the primary issue here is that we end up with selections that point to nodes in other documents. Currently, any selection must refer only to nodes in that frame's document. There are two ways to resolve this crash without major redesign. One is to fix things so that invariant is maintained. Another is to have the "node removed" code work on the parent frames too (or the entire frame tree). Created attachment 8703 [details]
patch
Comment on attachment 8703 [details]
patch
I think this might also fix 7165. r=me
Committed revision 14770. |