Bug 86156

Summary: Chromium Valgrind layout tests missing environment variables
Product: WebKit Reporter: Lei Zhang <thestig>
Component: Tools / TestsAssignee: Lei Zhang <thestig>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch to let the Chromium test scripts add the missing envvars. dpranke: review+, dpranke: commit-queue+

Description Lei Zhang 2012-05-10 16:37:08 PDT
Created attachment 141292 [details]
Patch to let the Chromium test scripts add the missing envvars.

I think recent changes made DumpRenderTree and ImageDiff run inside environments created by port.setup_environment_for_server(). As a result of these changes, the VALGRIND_LIB and VALGRIND_LIB_INNER envvars that the Chromium Valgrind script set got lost. We should put them back.
Comment 1 WebKit Review Bot 2012-05-10 16:39:50 PDT
Attachment 141292 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Dirk Pranke 2012-05-10 16:47:19 PDT
Committed r116703: <http://trac.webkit.org/changeset/116703>