Bug 86156

Summary:

Chromium Valgrind layout tests missing environment variables

Product:

WebKit

Reporter:

Lei Zhang <thestig>

Component:

Tools / Tests

Assignee:

Lei Zhang <thestig>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch to let the Chromium test scripts add the missing envvars.	dpranke: review+, dpranke: commit-queue+

Lei Zhang

Reported 2012-05-10 16:37:08 PDT

Created attachment 141292 [details] Patch to let the Chromium test scripts add the missing envvars. I think recent changes made DumpRenderTree and ImageDiff run inside environments created by port.setup_environment_for_server(). As a result of these changes, the VALGRIND_LIB and VALGRIND_LIB_INNER envvars that the Chromium Valgrind script set got lost. We should put them back.

Attachments
Patch to let the Chromium test scripts add the missing envvars. (1.58 KB, patch) 2012-05-10 16:37 PDT, Lei Zhang	dpranke: review+ dpranke: commit-queue+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

WebKit Review Bot

Comment 1 2012-05-10 16:39:50 PDT

Attachment 141292 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dirk Pranke

Comment 2 2012-05-10 16:47:19 PDT

Committed r116703: <http://trac.webkit.org/changeset/116703>

Note You need to log in before you can comment on or make changes to this bug.