Summary: | Integrate IETC CSS : xml namespace tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Tharp <dtharp> | ||||||
Component: | CSS | Assignee: | Dave Tharp <dtharp> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, rakuco, tomz, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
URL: | http://samples.msdn.microsoft.com/ietestcenter/#css3namespaces | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 81526 | ||||||||
Attachments: |
|
Description
Dave Tharp
2012-05-10 14:09:36 PDT
Created attachment 141252 [details]
Patch
Created attachment 141500 [details]
Patch
Committed r116808: <http://trac.webkit.org/changeset/116808> Attachment 141500 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/iete..." exit_code: 1
LayoutTests/platform/gtk/test_expectations.txt:1337: Path does not exist. svg/text/add-tspan-position-bug.html [test/expectations] [5]
LayoutTests/platform/gtk/test_expectations.txt:1338: Path does not exist. svg/text/modify-tspan-position-bug.html [test/expectations] [5]
Total errors found: 2 in 40 files
If any of these errors are false positives, please file a bug against check-webkit-style.
OK, so just to 'splain... Adam Barth r+'d the first patch. Merge and manual commit was required because of test_expectations conflict. As I was doing that, a well-intentioned gardener added bustage to gtk's expectations. I decided not to do gardener combat, and committed with the style violation. Hopefully that was OK. Patch expertly landed by tomz :) |