| Summary: | Move WebSQL tests in LayoutTests/storage to websql directory | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joshua Bell <jsbell> | ||||||||||||||
| Component: | Tools / Tests | Assignee: | Joshua Bell <jsbell> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | dbates, rniwa, webkit.review.bot | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | 86973 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 141262 [details]
Patch
Created attachment 141264 [details]
Patch
(In reply to comment #0) > * StorageInfo tests which are also in LayoutTests/storage/ Left those alone. > * Other non-WebSQL, non-StorageInfo tests??? None. > * LayoutTests/storage/resources/ - used by WebSQL tests, maybe StorageInfo? Only used by WebSQL tests, so moved that whole directory. Also, none of the WebSQL tests used resources elsewhere in the tree (no script src="../...") so none of the *.html/*.js/*-expected.txt files needed editing. > * Updating all platforms test expectations that refer to moved tests Done. Passes cleanly locally for me with Chromium/Linux port, we'll see what the bots say. Also need to ensure that no ports (e.g. Chromium) are running WebKit LayoutTests under other test harnesses. Created attachment 142343 [details]
Patch
Comment on attachment 142343 [details]
Patch
rs=me.
assuming you didn't break any tests :) Not technically blocked on 85742 but I'm not desperate enough to land this to get an svn checkout. Created attachment 143062 [details]
Patch
(In reply to comment #9) > Created an attachment (id=143062) [details] > Patch No need for review, already got an R+ from rniwa Uploading again now that https://bugs.webkit.org/show_bug.cgi?id=86973 is fixed and the bots should give this a real try. Also, EFL / GTK expectations needed updating. Created attachment 143071 [details]
Patch for landing
Comment on attachment 143071 [details] Patch for landing Rejecting attachment 143071 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: WebKit/chromium/v8 --revision 11594 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 11594. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Total errors found: 0 in 2 files Full output: http://queues.webkit.org/results/12739551 Created attachment 143089 [details]
Patch for landing
Comment on attachment 143089 [details] Patch for landing Clearing flags on attachment: 143089 Committed r117816: <http://trac.webkit.org/changeset/117816> All reviewed patches have been landed. Closing bug. |
LayoutTests/storage/ contains: LayoutTests/storage/indexeddb/ - Indexed Database tests LayoutTests/storage/domstorage/ - DOM Storage tests LayoutTests/storage/*.{html,txt} - mostly WebSQL tests, with webkitStorageInfo mixed in Moving the WebSQL tests to a dedicated directory would tidy things up. This is complicated by: * StorageInfo tests which are also in LayoutTests/storage/ * Other non-WebSQL, non-StorageInfo tests??? * LayoutTests/storage/resources/ - used by WebSQL tests, maybe StorageInfo? * Updating all platforms test expectations that refer to moved tests