Bug 86087

Summary: [chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebKit APIAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch none

Description Tommy Widenflycht 2012-05-10 05:12:32 PDT
Adding a missing adoptRef call. Adding code that exercises this to WebUserMediaClientMock.
Comment 1 Tommy Widenflycht 2012-05-10 05:18:18 PDT
Created attachment 141149 [details]
Patch
Comment 2 Adam Barth 2012-05-10 11:40:08 PDT
Comment on attachment 141149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141149&action=review

> Source/WebCore/ChangeLog:8
> +        Not easy to test but I have added code that excercises this to WebUserMediaClientMock (in DumpRenderTree).

You should be able to test it with a unit test.  http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/tests
Comment 3 WebKit Review Bot 2012-05-10 12:10:33 PDT
Comment on attachment 141149 [details]
Patch

Clearing flags on attachment: 141149

Committed r116674: <http://trac.webkit.org/changeset/116674>
Comment 4 WebKit Review Bot 2012-05-10 12:10:38 PDT
All reviewed patches have been landed.  Closing bug.