Bug 86066

Summary: [Qt] new test http/tests/cookies/single-quoted-value.html is failing
Product: WebKit Reporter: Kristóf Kosztyó <kkristof>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, ap, cmarcelo, ossy, tullio.lucena, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85775, 87008    
Attachments:
Description Flags
Patch
ossy: review+, webkit.review.bot: commit-queue-
Patch none

Description Kristóf Kosztyó 2012-05-10 01:19:46 PDT 
The test has been introduced in r116601. And it is failing on Qt.

--- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/cookies/single-quoted-value-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/cookies/single-quoted-value-actual.txt 
@@ -4,7 +4,7 @@
 
 
 Check that setting a cookie with a single-quoted value works.
-PASS cookie is 'singleQuoted="value'.
+FAIL cookie was 'singleQuoted="value;Version=1;Path=/'. Expected 'singleQuoted="value'.
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Kristóf Kosztyó 2012-05-10 01:26:02 PDT 
Committed r116621: <http://trac.webkit.org/changeset/116621>
Comment 2 Tullio Lucena 2012-10-04 14:09:02 PDT 
Created attachment 167171 [details]
Patch

Unskipping test.
Comment 3 Caio Marcelo de Oliveira Filho 2012-10-09 12:08:55 PDT 
It seems to me this was failing on the bot environment. Did something change to expect it's now passing?

Maybe we should do a trial run on this test in the bot to see if still fails there.
Comment 4 Csaba Osztrogonác 2012-10-09 12:18:08 PDT 
Comment on attachment 167171 [details]
Patch

I don't know what was the problem a half year before, but now it passes.
Comment 5 WebKit Review Bot 2012-10-09 12:23:50 PDT 
Comment on attachment 167171 [details]
Patch

Rejecting attachment 167171 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
zt..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/qt/TestExpectations
Hunk #1 FAILED at 2545.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/TestExpectations.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Csaba Oszt..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14229679
Comment 6 Tullio Lucena 2012-10-09 12:55:55 PDT 
Created attachment 167827 [details]
Patch

Updating last patch.
Comment 7 WebKit Review Bot 2012-10-09 21:48:12 PDT 
Comment on attachment 167827 [details]
Patch

Clearing flags on attachment: 167827

Committed r130842: <http://trac.webkit.org/changeset/130842>
Comment 8 WebKit Review Bot 2012-10-09 21:48:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Allan Sandfeld Jensen 2012-10-22 05:28:14 PDT 
It still fails on QtWebKit2.3