Bug 86011

Summary: CopiedSpace does not add pinned blocks back to the to-space filter
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Mark Hahnenberg
Reported 2012-05-09 13:26:54 PDT
After a collection has finished, we go through the blocks in from-space and move any of them that are pinned into to-space. At the beginning of collection, we reset the to-space block filter that is used during conservative scanning and add back the blocks that are filled during the collection. However, we neglect to add back those blocks that are moved from from-space to to-space, which can cause the conservative scan to think that some pinned items are not actually in CopiedSpace.
Attachments
Patch (2.20 KB, patch)
2012-05-09 13:33 PDT, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-05-09 13:33:59 PDT
Created attachment 141007 [details] Patch
Geoffrey Garen
Comment 2 2012-05-09 15:18:09 PDT
Comment on attachment 141007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141007&action=review r=me Please add Radar link > Source/JavaScriptCore/heap/CopiedSpace.cpp:186 > + // We don't add the block to the toSpaceSet because it was never removed. You should ASSERT this condition.
Mark Hahnenberg
Comment 3 2012-05-09 15:25:43 PDT
<rdar://problem/11417840>
Mark Hahnenberg
Comment 4 2012-05-09 15:49:52 PDT
Committed r116565: <http://trac.webkit.org/changeset/116565>
Note You need to log in before you can comment on or make changes to this bug.