Bug 85989

Summary: Textarea-placeholder-wrapping.html may fail because of scrollbars
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: Tools / TestsAssignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, rakuco, rniwa, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ec2-cr-linux-01
none
Patch
rniwa: review+, rniwa: commit-queue-
Increasing rows none

Dominik Röttsches (drott)
Reported 2012-05-09 06:36:51 PDT
I suggest to increase rows to 5 so that we avoid minimal scrollbar differences between the shadow DOM div element for the placeholder and the text of the textarea.
Attachments
Patch (2.31 KB, patch)
2012-05-09 06:40 PDT, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-01 (5.59 MB, application/zip)
2012-05-09 07:37 PDT, WebKit Review Bot 		no flags
Details
Patch (2.27 KB, patch)
2012-05-09 07:52 PDT, Dominik Röttsches (drott) 		rniwa: review+
rniwa: commit-queue-
DetailsFormatted DiffDiff
Increasing rows (2.27 KB, patch)
2012-05-09 09:28 PDT, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1 2012-05-09 06:40:25 PDT
Created attachment 140930 [details] Patch
WebKit Review Bot
Comment 2 2012-05-09 07:37:00 PDT
Comment on attachment 140930 [details] Patch Attachment 140930 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12647645 New failing tests: fast/forms/textarea-placeholder-wrapping.html
WebKit Review Bot
Comment 3 2012-05-09 07:37:12 PDT
Created attachment 140942 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Dominik Röttsches (drott)
Comment 4 2012-05-09 07:52:25 PDT
Created attachment 140944 [details] Patch
Ryosuke Niwa
Comment 5 2012-05-09 09:21:06 PDT
Comment on attachment 140944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140944&action=review > LayoutTests/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). Oops, this line needs to appear before the description.
Dominik Röttsches (drott)
Comment 6 2012-05-09 09:28:18 PDT
Created attachment 140959 [details] Increasing rows
Dominik Röttsches (drott)
Comment 7 2012-05-09 09:33:09 PDT
(In reply to comment #6) > Created an attachment (id=140959) [details] > Increasing rows And Reviewed-by line put in the right place.
Ryosuke Niwa
Comment 8 2012-05-09 10:26:35 PDT
Comment on attachment 140959 [details] Increasing rows View in context: https://bugs.webkit.org/attachment.cgi?id=140959&action=review > LayoutTests/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). In the future, you need to replace NOBODY (OOPS!) by reviewer's name when asking for cq+ without a review. Otherwise commit queue is going to reject your patch.
Ryosuke Niwa
Comment 9 2012-05-09 10:26:41 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=140959&action=review > LayoutTests/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). In the future, you need to replace NOBODY (OOPS!) by reviewer's name when asking for cq+ without a review. Otherwise commit queue is going to reject your patch.
Dominik Röttsches (drott)
Comment 10 2012-05-09 10:35:08 PDT
Understood, thanks!
WebKit Review Bot
Comment 11 2012-05-09 10:46:20 PDT
Comment on attachment 140959 [details] Increasing rows Clearing flags on attachment: 140959 Committed r116542: <http://trac.webkit.org/changeset/116542>
WebKit Review Bot
Comment 12 2012-05-09 10:46:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.