Summary: | ElementShadow should minimize the usage of "ShadowRoot" name | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||||||||||
Component: | DOM | Assignee: | Hajime Morrita <morrita> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | dglazkov, eric.carlson, eric, feature-media-reviews, tkent, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 85263 | ||||||||||||||||
Attachments: |
|
Description
Hajime Morrita
2012-05-09 02:22:00 PDT
Created attachment 141091 [details]
Patch
Hi Dimitri, could you take a look at this cleanup exercise? Comment on attachment 141091 [details] Patch Attachment 141091 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12648773 Comment on attachment 141091 [details] Patch Attachment 141091 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12644953 Created attachment 141099 [details]
Patch
Comment on attachment 141091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141091&action=review Looks reasonable. > Source/WebCore/dom/ElementShadow.cpp:93 > // Dont protect this ref count. This comment can be improved by explaining why. > Source/WebCore/html/HTMLMediaElement.cpp:4077 > + ElementShadow* shadow = this->shadow(); Should we name this variable elementShadow so that you don't have to use this pointer? > Source/WebCore/inspector/InspectorDOMAgent.cpp:1234 > + ElementShadow* shadow = element->shadow(); > + if (shadow) { You should declare shadow inside the if. Comment on attachment 141099 [details]
Patch
Please address the comment I posted above.
Comment on attachment 141099 [details] Patch Attachment 141099 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12664249 Created attachment 141111 [details]
Patch
Created attachment 141298 [details]
Patch for landing
Ryosuke, Dimitri, thanks for reviewing! The landing patch addresses Ryosuke's comment. Created attachment 141300 [details]
Patch for landing
Created attachment 141303 [details]
Patch for landing
Comment on attachment 141303 [details] Patch for landing Clearing flags on attachment: 141303 Committed r116730: <http://trac.webkit.org/changeset/116730> All reviewed patches have been landed. Closing bug. |