Bug 85970

Summary: ElementShadow should minimize the usage of "ShadowRoot" name
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric.carlson, eric, feature-media-reviews, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85263    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Hajime Morrita
Reported 2012-05-09 02:22:00 PDT
Since ElementShadow exists for encapsulate the shadow dom concept, it doesn't makes sense to have these names in API.
Attachments
Patch (41.50 KB, patch)
2012-05-09 23:23 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (45.56 KB, patch)
2012-05-10 00:31 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (47.33 KB, patch)
2012-05-10 01:59 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (48.17 KB, patch)
2012-05-10 17:22 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (48.17 KB, patch)
2012-05-10 17:49 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (48.17 KB, patch)
2012-05-10 18:01 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-05-09 23:23:33 PDT
Created attachment 141091 [details] Patch
Hajime Morrita
Comment 2 2012-05-09 23:24:30 PDT
Hi Dimitri, could you take a look at this cleanup exercise?
Build Bot
Comment 3 2012-05-09 23:50:43 PDT
Comment on attachment 141091 [details] Patch Attachment 141091 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12648773
Build Bot
Comment 4 2012-05-09 23:53:01 PDT
Comment on attachment 141091 [details] Patch Attachment 141091 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12644953
Hajime Morrita
Comment 5 2012-05-10 00:31:49 PDT
Created attachment 141099 [details] Patch
Ryosuke Niwa
Comment 6 2012-05-10 00:36:17 PDT
Comment on attachment 141091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141091&action=review Looks reasonable. > Source/WebCore/dom/ElementShadow.cpp:93 > // Dont protect this ref count. This comment can be improved by explaining why. > Source/WebCore/html/HTMLMediaElement.cpp:4077 > + ElementShadow* shadow = this->shadow(); Should we name this variable elementShadow so that you don't have to use this pointer? > Source/WebCore/inspector/InspectorDOMAgent.cpp:1234 > + ElementShadow* shadow = element->shadow(); > + if (shadow) { You should declare shadow inside the if.
Ryosuke Niwa
Comment 7 2012-05-10 00:37:10 PDT
Comment on attachment 141099 [details] Patch Please address the comment I posted above.
Build Bot
Comment 8 2012-05-10 01:00:43 PDT
Comment on attachment 141099 [details] Patch Attachment 141099 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12664249
Hajime Morrita
Comment 9 2012-05-10 01:59:39 PDT
Created attachment 141111 [details] Patch
Hajime Morrita
Comment 10 2012-05-10 17:22:40 PDT
Created attachment 141298 [details] Patch for landing
Hajime Morrita
Comment 11 2012-05-10 17:23:37 PDT
Ryosuke, Dimitri, thanks for reviewing! The landing patch addresses Ryosuke's comment.
Hajime Morrita
Comment 12 2012-05-10 17:49:47 PDT
Created attachment 141300 [details] Patch for landing
Hajime Morrita
Comment 13 2012-05-10 18:01:19 PDT
Created attachment 141303 [details] Patch for landing
WebKit Review Bot
Comment 14 2012-05-10 22:34:31 PDT
Comment on attachment 141303 [details] Patch for landing Clearing flags on attachment: 141303 Committed r116730: <http://trac.webkit.org/changeset/116730>
WebKit Review Bot
Comment 15 2012-05-10 22:34:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.