Bug 85956 – [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Chris Dumez]

EFL's DRT does not print didFailProvisionalLoadWithError messages.

This causes the following test to fail:
http/tests/loading/pdf-commit-load-callbacks.html

[Chris Dumez]

Created attachment 140879 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 140879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140879&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:2970
> +    evas_object_smart_callback_call(ewkView, "load,provisional,failed", (void*)error);

It looks you are missing to write this signal description in ewk_view.h.

[Chris Dumez]

Created attachment 140887 [details]
Patch

Take feedback into consideration.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 140887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140887&action=review

Do you have any idea why the expectation varies for the PDF test across ports? Shouldn't our version match GTK's?

> Source/WebKit/efl/ewk/ewk_frame.cpp:1380
> +    evas_object_smart_callback_call(ewkFrame, "load,provisional,failed", (void*)error);

Please don't use C-style casts.

> Source/WebKit/efl/ewk/ewk_view.cpp:2970
> +    evas_object_smart_callback_call(ewkView, "load,provisional,failed", (void*)error);

Ditto.

[Chris Dumez]

Here is the diff between our expectations and GTK's:
--- LayoutTests/platform/efl/http/tests/loading/pdf-commit-load-callbacks-expected.txt	2012-05-10 09:55:07.259467379 +0300
+++ LayoutTests/platform/gtk/http/tests/loading/pdf-commit-load-callbacks-expected.txt	2012-05-09 11:14:37.317981072 +0300
@@ -3,6 +3,5 @@
 frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
 main frame - didFinishDocumentLoadForFrame
 main frame - didHandleOnloadEventsForFrame
-frame "<!--framePath //<!--frame0-->-->" - didFailProvisionalLoadWithError
 main frame - didFinishLoadForFrame

Basically, the GTK port does not print out "didFailProvisionalLoadWithError" messages yet.

For this reason, we are using the same expectations as Qt, which has support for "didFailProvisionalLoadWithError" messages.

I'll reupload a patch with the casting issues fixed.

[Chris Dumez]

Created attachment 141097 [details]
Patch

Removed C-style casts.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 141097 [details]
Patch

Looks OK.

[Chris Dumez]

For reference, the platform-specific expected results were introduced by:
https://bugs.webkit.org/show_bug.cgi?id=85275

[Gustavo Noronha (kov)]

Comment on attachment 141097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=141097&action=review

cq- because of the nit

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:583
> +    // signals. m_provisionalLoadFailedFrame is used to avoid printing twice the load error in

Adding a colon after 'error' here would make this clearer I believe.

[Chris Dumez]

Created attachment 143466 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 143466 [details]
Patch for landing

Clearing flags on attachment: 143466

Committed r118142: <http://trac.webkit.org/changeset/118142>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.