Summary: | [Chromium] Layout Test http/tests/media/media-source/webm/video-media-source-*.html is flaky | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | Tools / Tests | Assignee: | Ami Fischman <fischman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | acolwell, dominicc, eric.carlson, feature-media-reviews, fischman, pkasting, schenney, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kent Tamura
2012-05-08 20:36:00 PDT
I found they were not slow, they sometimes timed out. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmedia%2Fmedia-source%2Fwebm%2Fvideo-media- I updated test_expectations.txt: BUGWK85952 MAC WIN : http/tests/media/media-source/webm/video-media-source-play.html = PASS TIMEOUT BUGWK85952 WIN : http/tests/media/media-source/webm/video-media-source-seek.html = PASS TIMEOUT BUGWK85952 WIN : http/tests/media/media-source/webm/video-media-source-state-changes.html = PASS TIMEOUT BUGWK85952 MAC DEBUG : http/tests/media/media-source/webm/video-media-source-state-changes.html = PASS TEXT Committed r118917: <http://trac.webkit.org/changeset/118917> I broadened the expectation to include timeout on all platforms. I updated the expectations for video-media-source-seek.html to include TEXT in r120157 because the EVENT(webkitsourceended) message races with the EVENT(seeked) event causing text diffs. This mostly seems to be happening on Linux Debug: <http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmedia%2Fmedia-source%2Fvideo-media-source-seek.html> Created attachment 155671 [details]
Patch
Comment on attachment 155671 [details] Patch Clearing flags on attachment: 155671 Committed r124286: <http://trac.webkit.org/changeset/124286> All reviewed patches have been landed. Closing bug. Reopening. http/tests/media/media-source/video-media-source-play.html still times out on most bots. Per fischman I'm going to revert this line of the test expectations and left the rest of the patch in place. Created attachment 156467 [details]
Patch
Comment on attachment 156467 [details] Patch Clearing flags on attachment: 156467 Committed r124687: <http://trac.webkit.org/changeset/124687> All reviewed patches have been landed. Closing bug. |