Bug 85897

Summary: [Chromium] OS(ANDROID) ImageDiff requires us to build WTF for both host and target
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, johnme, peter, tony, webkit.review.bot, zhenghao
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 85904    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-05-08 10:35:30 PDT
[Chromium] OS(ANDROID) ImageDiff requires us to build WTF for both host and target
Attachments
Patch (1.51 KB, patch)
2012-05-08 10:36 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-05-08 10:36:46 PDT
Created attachment 140739 [details] Patch
Tony Chang
Comment 2 2012-05-08 10:48:27 PDT
Comment on attachment 140739 [details] Patch What is android_build_type?
Tony Chang
Comment 3 2012-05-08 11:05:47 PDT
Comment on attachment 140739 [details] Patch Peter explained to me what android_build_type is. LGTM.
Peter Beverloo
Comment 4 2012-05-08 11:14:50 PDT
Confirmed this works fine, patch LGTM as well. Thanks Adam!
WebKit Review Bot
Comment 5 2012-05-08 11:44:30 PDT
Comment on attachment 140739 [details] Patch Clearing flags on attachment: 140739 Committed r116440: <http://trac.webkit.org/changeset/116440>
WebKit Review Bot
Comment 6 2012-05-08 11:44:35 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2012-05-08 12:08:27 PDT
Re-opened since this is blocked by 85904
Hao Zheng
Comment 8 2012-05-08 19:50:10 PDT
I remember I have removed the dependency on wtf of ImageDiff. Why we need it again?
Hao Zheng
Comment 9 2012-05-08 19:51:17 PDT
Oh, sorry. I didn't notice replying the bug would reopen it.
Adam Barth
Comment 10 2012-05-08 20:36:11 PDT
(In reply to comment #8) > I remember I have removed the dependency on wtf of ImageDiff. Why we need it again? Ah, that means we can fix this downstream. Thanks!
Note You need to log in before you can comment on or make changes to this bug.