Bug 85892

Summary:

[chromium] Check whether an active document loader exists before accessing it

Product:

WebKit

Reporter:

jochen

Component:

New Bugs

Assignee:

jochen

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

jochen

Reported 2012-05-08 09:56:14 PDT

[chromium] Check whether an active document loader exists before accessing it

Attachments
Patch (1.84 KB, patch) 2012-05-08 09:57 PDT, jochen	no flags	Details Formatted Diff Diff
Patch (2.51 KB, patch) 2012-05-09 12:07 PDT, jochen	no flags	Details Formatted Diff Diff
Patch (2.51 KB, patch) 2012-05-09 12:49 PDT, jochen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

jochen

Comment 1 2012-05-08 09:57:22 PDT

Created attachment 140732 [details] Patch

Nate Chapin

Comment 2 2012-05-08 12:02:35 PDT

Comment on attachment 140732 [details] Patch Any chance of a layout test for this?

Eric Seidel (no email)

Comment 3 2012-05-08 15:38:59 PDT

Comment on attachment 140732 [details] Patch It seems like webView->page()->mainFrame()->loader() would be a useful local here. :) Also, how do we test this?

jochen

Comment 4 2012-05-09 12:07:57 PDT

Created attachment 140992 [details] Patch

jochen

Comment 5 2012-05-09 12:08:45 PDT

I tried to come up with a test but failed Although FrameLoader::loadInSameDocument which invokes this method does not have a provisional document loader, we're seeing crashes where the FrameLoader is in provisional state, and thus activeDocumentLoader returns NULL. Lacking any understanding of how this can happen, we do this check here to avoid crashing.

WebKit Review Bot

Comment 6 2012-05-09 12:11:42 PDT

Attachment 140992 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:642: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

jochen

Comment 7 2012-05-09 12:49:21 PDT

Created attachment 140999 [details] Patch

Eric Seidel (no email)

Comment 8 2012-05-09 13:19:04 PDT

Comment on attachment 140999 [details] Patch Thank you. Sometimes we fight the loader and the loader wins.

WebKit Review Bot

Comment 9 2012-05-09 14:16:52 PDT

Comment on attachment 140999 [details] Patch Clearing flags on attachment: 140999 Committed r116556: <http://trac.webkit.org/changeset/116556>

WebKit Review Bot

Comment 10 2012-05-09 14:17:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.