| Summary: | [chromium] move event_listener_unittest to webkit_unit_tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, jamesr, ojan, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 85850 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Tony Chang
2012-05-07 15:26:57 PDT
Created attachment 140609 [details]
Patch
First step in fixing https://code.google.com/p/chromium/issues/detail?id=126514 . Comment on attachment 140609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140609&action=review Death to test_shell_tests (and test_shell)! > Source/WebKit/chromium/tests/EventListenerTest.cpp:78 > + std::string baseURL("http://www.test.com/"); nit: shouldn't we use example.com ? test.com is a real domain, example.com is an RFC 2606 (?) placeholder > Source/WebKit/chromium/tests/data/listener/mutation_event_listener.html:1 > +<html> <!DOCTYPE html> unless we need quirks mode for this test Created attachment 140610 [details]
Patch for landing
(In reply to comment #3) > (From update of attachment 140609 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140609&action=review > > Death to test_shell_tests (and test_shell)! > > > Source/WebKit/chromium/tests/EventListenerTest.cpp:78 > > + std::string baseURL("http://www.test.com/"); > > nit: shouldn't we use example.com ? test.com is a real domain, example.com is an RFC 2606 (?) placeholder Fixed. > > Source/WebKit/chromium/tests/data/listener/mutation_event_listener.html:1 > > +<html> > > <!DOCTYPE html> unless we need quirks mode for this test Added. Thanks for the fast review! Comment on attachment 140610 [details] Patch for landing Clearing flags on attachment: 140610 Committed r116375: <http://trac.webkit.org/changeset/116375> All reviewed patches have been landed. Closing bug. The patch caused build errors on Chromium-win and Chromium-mac. I'm rolling it out soon. 1: .\tests\EventListenerTest.cpp(76) : error C2146: syntax error : missing ';' before identifier 'SetUp' 2: .\tests\EventListenerTest.cpp(76) : error C2182: 'override' : illegal use of type 'void' 3: .\tests\EventListenerTest.cpp(76) : error C2433: '`anonymous-namespace'::WebDOMEventListenerTest::override' : 'virtual' not permitted on data declarations 4: .\tests\EventListenerTest.cpp(77) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 5: .\tests\EventListenerTest.cpp(85) : error C2146: syntax error : missing ';' before identifier 'TearDown' 6: .\tests\EventListenerTest.cpp(85) : error C2182: 'override' : illegal use of type 'void' 7: .\tests\EventListenerTest.cpp(85) : error C2433: '`anonymous-namespace'::WebDOMEventListenerTest::override' : 'virtual' not permitted on data declarations 8: .\tests\EventListenerTest.cpp(85) : error C2086: 'int `anonymous-namespace'::WebDOMEventListenerTest::override' : redefinition 9: .\tests\EventListenerTest.cpp(86) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 10: .\tests\EventListenerTest.cpp(117) : error C2555: '`anonymous-namespace'::WebDOMEventListenerTest::SetUp': overriding virtual function return type differs and is not covariant from 'testing::Test::SetUp' 11: .\tests\EventListenerTest.cpp(117) : error C2555: '`anonymous-namespace'::WebDOMEventListenerTest::TearDown': overriding virtual function return type differs and is not covariant from 'testing::Test::TearDown' oh - OVERRIDE has to go after the function name, not before it. It's an easy mechanical fix if you want to do that instead of reverting Re-opened since this is blocked by 85850 Rolled out by http://trac.webkit.org/changeset/116383 Committed r116433: <http://trac.webkit.org/changeset/116433> (In reply to comment #12) > Committed r116433: <http://trac.webkit.org/changeset/116433> Landed with the syntax fix. I verified that it compiled using clang. |