Bug 85810

Summary: IndexedDB: LevelDB coding for bools is broken
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dgrogan, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Joshua Bell 2012-05-07 10:53:32 PDT
IndexedDB: LevelDB coding for bools is broken
Comment 1 Joshua Bell 2012-05-07 10:59:15 PDT
Created attachment 140553 [details]
Patch
Comment 2 Joshua Bell 2012-05-07 11:02:26 PDT
Fix for http://crbug.com/126388 broken by webkit roll including http://webkit.org/b/85557

My bad. My patch for http://webkit.org/b/85557 expanded after review and (1) I didn't get it re-reviewed, and (2) I didn't add unit tests despite a lovely pre-existing setup for them.

Fix is simple, and added unit tests.

tony@ - r?
Comment 3 WebKit Review Bot 2012-05-07 11:54:05 PDT
Comment on attachment 140553 [details]
Patch

Clearing flags on attachment: 140553

Committed r116333: <http://trac.webkit.org/changeset/116333>
Comment 4 WebKit Review Bot 2012-05-07 11:54:10 PDT
All reviewed patches have been landed.  Closing bug.