Fix containerForRepaint() assumption about non-null enclosingLayer()

• Component: New Bugs
• Status: RESOLVED FIXED

[Adrienne Walker]

Fix containerForRepaint() assumption about non-null enclosingLayer()

[Adrienne Walker]

Created attachment 140545 [details]
Failing test

[Adrienne Walker]

Created attachment 140547 [details]
Patch

[Adrienne Walker]

smfr: I looked into why https://chromiumcodereview.appspot.com/10342008/ got reverted on the Chromium branch, and it turned out that there was a crash that (mistakenly) looked like it started occurring because of your change.  So, it was conservatively reverted on the branch.  I've attached the messy autogenerated test that was triggering it.

However, that revision range ended up being incorrect and it wasn't due to your patch.  This is a pretty obvious fix, so I just went ahead and patched it.

[WebKit Review Bot]

Comment on attachment 140547 [details]
Patch

Rejecting attachment 140547 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/RenderObject.cpp
Hunk #1 FAILED at 1243.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderObject.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Simon Fras..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12644206

[Adrienne Walker]

Created attachment 140562 [details]
Rebased for landing

[WebKit Review Bot]

Comment on attachment 140562 [details]
Rebased for landing

Clearing flags on attachment: 140562

Committed r116339: <http://trac.webkit.org/changeset/116339>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.