| Summary: | [chromium] setContentsMemoryAllocationLimitBytes needs to setNeedsCommit. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michal Mocny <mmocny> | ||||||
| Component: | New Bugs | Assignee: | Michal Mocny <mmocny> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cc-bugs, enne, jamesr, kbr, nduca, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Michal Mocny
2012-05-07 06:59:51 PDT
Created attachment 140523 [details]
Patch
Comment on attachment 140523 [details] Patch This patch fixes: http://code.google.com/p/chromium/issues/detail?id=126079 On pages that did not need to update/draw, we would push a single white frame while our memory allocation was 0, and not push another frame once that memory allocation changed. As well as calling setNeedsCommit, this patch resets the memory allocation to its initial value on visibility if it was purged down to 0. This way, we can push a frame before waiting for a round trip memory allocation adjustments message to arrive. If the message arrives before the next frame, great. If not, at least our allocation is some conservative non 0 value, and also matches our current initialized state behaviour. Comment on attachment 140523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140523&action=review > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:382 > + // Reset memory allocation to initial value if we have purged down to 0. Why? This feels wrong... you're basically goign to let any newly visible tab ignore the gpu memory manager's recommendation? > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:427 > + setNeedsCommit(); This part LGTM Created attachment 140535 [details]
Patch
Comment on attachment 140523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140523&action=review >> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:382 >> + // Reset memory allocation to initial value if we have purged down to 0. > > Why? This feels wrong... you're basically goign to let any newly visible tab ignore the gpu memory manager's recommendation? Discussed offline: it should be a separate bug to optimize returning from 0 memory allocation, as there are many possible solutions to this. Removing from this patch for now. Comment on attachment 140535 [details]
Patch
R=me. I agree with the approach of fixing this first and optimizing it later.
Comment on attachment 140535 [details] Patch Clearing flags on attachment: 140535 Committed r116316: <http://trac.webkit.org/changeset/116316> All reviewed patches have been landed. Closing bug. |