Bug 85774

Summary: [Shadow] Drop events aren’t fired on nodes in Shadow DOM
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, hayato, morrita, shinyak, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jsfiddle.net/eH8Ye/
Bug Depends on:    
Bug Blocks: 87230    
Attachments:
Description Flags
Patch none

Dominic Cooney
Reported 2012-05-06 22:56:50 PDT
This was reported as <http://code.google.com/p/chromium/issues/detail?id=125975> with a repro at <http://jsfiddle.net/eH8Ye/>: 1. Drag a file onto the blue square – note the event fires. 2. Drag a file onto the red square – event does not fire. Expected behavior is that a similar event fires in both cases.
Attachments
Patch (5.82 KB, patch)
2012-05-22 21:40 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-05-16 03:39:22 PDT
Let me investigate it. Today, I encountered the similar issue that 'mouseover' event is not dispatched correctly for nodes in the Shadow DOM subtree. They seems to share the same code at first glance.
Shinya Kawanaka
Comment 2 2012-05-22 21:25:51 PDT
I found that a code to re-target drop event to shadowAncestor in EventHandler.cpp. Now that event retargeting has been implemented, I think we don't need to retarget in EventHandler. I'll prepare a patch soon.
Shinya Kawanaka
Comment 3 2012-05-22 21:40:06 PDT
Created attachment 143456 [details] Patch
WebKit Review Bot
Comment 4 2012-05-23 18:39:45 PDT
Comment on attachment 143456 [details] Patch Clearing flags on attachment: 143456 Committed r118298: <http://trac.webkit.org/changeset/118298>
WebKit Review Bot
Comment 5 2012-05-23 18:39:49 PDT
All reviewed patches have been landed. Closing bug.
Lucas Forschler
Comment 6 2019-02-06 09:18:56 PST
Mass move bugs into the DOM component.
Note You need to log in before you can comment on or make changes to this bug.