Bug 85773

Summary: REGRESSION(r116235): broke a lot of tests on all chromium debug bots (Requested by caseq_ on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85598    
Attachments:
Description Flags
ROLLOUT of r116235 koivisto: commit-queue-

Description WebKit Review Bot 2012-05-06 22:39:36 PDT
http://trac.webkit.org/changeset/116235 broke the build:
broke a lot of tests on all chromium debug bots (Requested by caseq_ on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-05-06 22:40:36 PDT
Created attachment 140480 [details]
ROLLOUT of r116235

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Antti Koivisto 2012-05-07 01:02:29 PDT
This is about scoped style sheet feature that some chromium bots have enabled. Should be easy fix.

STDERR: ASSERTION FAILED: root->m_clients.size() == 1
STDERR: /Volumes/data/b/build/slave/webkit-mac-latest-dbg/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../css/CSSStyleSheet.cpp(409) : WebCore::Node *WebCore::StyleSheetInternal::singleOwnerNode() const
STDERR: 1   0x20ccbca3 WebCore::StyleSheetInternal::singleOwnerNode() const
STDERR: 2   0x20db1a09 WebCore::StyleResolver::determineScope(WebCore::StyleSheetInternal const*)
STDERR: 3   0x20db0f50 WebCore::StyleResolver::appendAuthorStylesheets(unsigned int, WTF::Vector<WTF::RefPtr<WebCore::StyleSheet>, 0ul> const&)
STDERR: 4   0x1e7e5738 WebCore::Document::updateActiveStylesheets(WebCore::StyleResolverUpdateFlag)
STDERR: 5   0x1e7e1d3e WebCore::Document::styleResolverChanged(WebCore::StyleResolverUpdateFlag)
STDERR: 6   0x1e7ece46 WebCore::Document::removePendingSheet()
STDERR: 7   0x2027c423 WebCore::HTMLLinkElement::removePendingSheet()
STDERR: 8   0x2027e542 WebCore::HTMLLinkElement::sheetLoaded()
Comment 3 Antti Koivisto 2012-05-07 01:13:32 PDT
Landed a quick fix in

http://trac.webkit.org/changeset/116281
Comment 4 Antti Koivisto 2012-05-07 01:45:38 PDT
Uh, apparently the rollout had landed in

http://trac.webkit.org/changeset/116276

without any comment here.