Bug 85749 – Update FeatureDefines.xcconfig files to list all ENABLE_ macros

• Component: New Bugs
• Status: NEW

[Eric Seidel (no email)]

Update FeatureDefines.xcconfig files to list all ENABLE_ macros

[Eric Seidel (no email)]

Created attachment 140437 [details]
Patch

[Eric Seidel (no email)]

This change also includes a re-sort of the FEATURE_DEFINES = list at the bottom (as well as removing some missing defines from that list).

This diff was generated by using the generate-feature-files script, which I will shortly be attaching to bug 85456.


I would like someone very familiar with the Mac port to review this change.  I'm not trying to add/remove any features here, just trying to make the list complete.

If having a complete list is incompatible with the Mac or iOS build process, we can look for a different solution, but hopefully this will make this more clear both for all persons dealing with these FeatureDefines.xcconfig files, as the list is now complete. :)

[Eric Seidel (no email)]

Comment on attachment 140437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140437&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:107
> +ENABLE_NETSCAPE_PLUGIN_API = $(ENABLE_NETSCAPE_PLUGIN_API_$(REAL_PLATFORM_NAME));
> +ENABLE_NETSCAPE_PLUGIN_API_macosx = ENABLE_NETSCAPE_PLUGIN_API;

Even though it does not appear that this file is kept up-to-date with the iOS build, I attempted to make this match the iOS feature defines as much as possible.  In this case, NETSCAPE_PLUGIN_API is clearly off on iOS (per Platform.h), so the generator only enabled the plugin API on Mac.

[Eric Seidel (no email)]

Comment on attachment 140437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140437&action=review

>> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:107
>> +ENABLE_NETSCAPE_PLUGIN_API_macosx = ENABLE_NETSCAPE_PLUGIN_API;
> 
> Even though it does not appear that this file is kept up-to-date with the iOS build, I attempted to make this match the iOS feature defines as much as possible.  In this case, NETSCAPE_PLUGIN_API is clearly off on iOS (per Platform.h), so the generator only enabled the plugin API on Mac.

If you believe any of these enables are incorrect, for either Mac or iOS, i'm very happy to fix them!

[Eric Seidel (no email)]

Comment on attachment 140437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140437&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:62
> +ENABLE_GESTURE_EVENTS = ;

I need to fix this.  ENABLE_GESTURE_EVENTS should be on for Lion and above it seems.  This wouldn't break anything (due to the way Platform.h is written), but it's still wrong.

[Eric Seidel (no email)]

Comment on attachment 140437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140437&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:114
> +ENABLE_ORIENTATION_EVENTS = ;

iOS has ORIENTATION_EVENTS on.  It's unclear if the Mac maintainers want that fixed here or not, since my understanding is that this xcconfig is not up-to-date with iOS.  I'm happy to attempt to sync this file with my (or someone elses) current understanding of iOS defines if that's desired.