Bug 85710

Summary: Web Inspector: convert standalone functions save/append/savedURL/appendedToURL into WebInspector.FileManager object.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
yurys: review+
actually landed none

Ilya Tikhonovsky
Reported 2012-05-05 07:47:18 PDT
The idea is to have an object and be able to add/remove event listeners from it.
Attachments
Patch (14.69 KB, patch)
2012-05-05 07:49 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
actually landed (18.12 KB, patch)
2012-05-05 08:35 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-05-05 07:49:24 PDT
Created attachment 140399 [details] Patch
Yury Semikhatsky
Comment 2 2012-05-05 07:58:32 PDT
Comment on attachment 140399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140399&action=review > Source/WebCore/inspector/front-end/HeapSnapshotView.js:872 > + return this._loaded && !this._savedChunksCount && WebInspector.fileManager.canAppendTo(); canAppendTo -> canAppend as there is no argument. > Source/WebCore/inspector/front-end/HeapSnapshotView.js:878 > + _startWritingSnapshot: function(event) I'd leave this function internal to save(), you should be able to remove it as WebInspector.fileManager.removeEventListener(WebInspector.FileManager.EventTypes.SavedURL, startWritingSnapshot, this); > Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:184 > +WebInspector.FileManager = function() Move it to a separate file?
Ilya Tikhonovsky
Comment 3 2012-05-05 08:32:28 PDT
Committed r116222: <http://trac.webkit.org/changeset/116222>
Ilya Tikhonovsky
Comment 4 2012-05-05 08:35:08 PDT
(In reply to comment #2) > (From update of attachment 140399 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140399&action=review > > > Source/WebCore/inspector/front-end/HeapSnapshotView.js:872 > > + return this._loaded && !this._savedChunksCount && WebInspector.fileManager.canAppendTo(); done > > canAppendTo -> canAppend as there is no argument. > > > Source/WebCore/inspector/front-end/HeapSnapshotView.js:878 > > + _startWritingSnapshot: function(event) > > I'd leave this function internal to save(), you should be able to remove it as WebInspector.fileManager.removeEventListener(WebInspector.FileManager.EventTypes.SavedURL, startWritingSnapshot, this); done > > > Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:184 > > +WebInspector.FileManager = function() > > Move it to a separate file? done
Ilya Tikhonovsky
Comment 5 2012-05-05 08:35:55 PDT
Created attachment 140403 [details] actually landed
Note You need to log in before you can comment on or make changes to this bug.