Summary: | layoutTestController.overridePreference doesn't work so well in a parallel world | ||
---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | ap, dpranke, simon.fraser, thorton, zan |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Dean Jackson
2012-05-04 19:14:49 PDT
I'm surprised that setting a pref in DRT interferes with other DRT instances; it should never get written to disk. How does that not break with other prefs? It surprises me as well - but I certainly see my setting if I run defaults read DumpRenderTree Maybe this is not an issue normally because DRT sets prefs to default values before every test. (In reply to comment #3) > Maybe this is not an issue normally because DRT sets prefs to default values before every test. Even so, if the DRT instances are sharing preferences, isn't it still possible for a different one to set it between resetWebViewToConsistentStateBeforeTesting() and the test running? From the test's point of view, setting the preference to preferred value could be done through the window.internals object. Is that an acceptable workaround? (In reply to comment #5) > From the test's point of view, setting the preference to preferred value could be done through the window.internals object. Is that an acceptable workaround? To clarify, the test in mind here is fast/animation/request-animation-frame-disabled.html. |