| Summary: | [BlackBerry] Add methods need by client side | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Crystal Zhang <haizhang> | ||||||||||||||
| Component: | WebKit BlackBerry | Assignee: | Crystal Zhang <haizhang> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | rwlbuis, staikos, tonikitoo, webkit.review.bot | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Attachment 140314 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPageClient..." exit_code: 1
Source/WebKit/blackberry/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit/blackberry/Api/WebPageClient.h:254: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 140318 [details]
updated patch
Comment on attachment 140318 [details]
updated patch
Looks good.
Comment on attachment 140318 [details] updated patch Rejecting attachment 140318 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/12543443 Created attachment 140329 [details]
fix commit error
Comment on attachment 140329 [details]
fix commit error
Second attempt.
Comment on attachment 140329 [details] fix commit error Rejecting attachment 140329 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/12543452 Created attachment 140345 [details]
patch4
Comment on attachment 140345 [details]
patch4
Why is this not passing IntRect by const&?
Comment on attachment 140345 [details] patch4 View in context: https://bugs.webkit.org/attachment.cgi?id=140345&action=review patches does not apply against ToT! > Source/WebKit/blackberry/Api/WebPageClient.h:254 > + virtual void createPopupWebView(Platform::IntRect) = 0; const Platform::IntRect& and please name the parameter, if it has a meaningful name.
> patches does not apply against ToT!
err, patch*
Created attachment 140526 [details]
patch5
Comment on attachment 140526 [details] patch5 View in context: https://bugs.webkit.org/attachment.cgi?id=140526&action=review > Source/WebKit/blackberry/Api/WebPageClient.h:255 > + virtual void createPopupWebView(Platform::IntRect) = 0; > + virtual void closePopupWebView() = 0; could you pass a 'const Platform::IntRect&' here, or you want a copy? Also please name the parameter as it is unclear what it is about. > Source/WebKit/blackberry/ChangeLog:8 > + Add methods need by client side when create and close HTML popup dialogs. typo: needed Created attachment 140529 [details]
patch6
Comment on attachment 140529 [details] patch6 Clearing flags on attachment: 140529 Committed r116318: <http://trac.webkit.org/changeset/116318> All reviewed patches have been landed. Closing bug. |
Created attachment 140314 [details] patch The two APIs needed by client side.