Bug 85636

Summary: fix bit packing in FillLayer on Windows
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Tony Chang 2012-05-04 10:12:14 PDT 
fix bit packing in FillLayer on Windows
Comment 1 Tony Chang 2012-05-04 10:15:56 PDT 
Created attachment 140262 [details]
Patch
Comment 2 Tony Chang 2012-05-04 10:17:46 PDT 
I saw this in a patch on bug 37514.
Comment 3 Ryosuke Niwa 2012-05-04 10:22:24 PDT 
Comment on attachment 140262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140262&action=review

> Source/WebCore/rendering/style/FillLayer.cpp:40
> +COMPILE_ASSERT(sizeof(FillLayer) == sizeof(SameSizeAsFillLayer), FillLayer_should_not_grow);

I think we normally call these assertions FillLayer_should_stay_small. We should probably get rid of underscores at some point...
Comment 4 Tony Chang 2012-05-04 10:42:25 PDT 
Created attachment 140270 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-05-04 11:27:23 PDT 
Comment on attachment 140270 [details]
Patch for landing

Clearing flags on attachment: 140270

Committed r116129: <http://trac.webkit.org/changeset/116129>
Comment 6 WebKit Review Bot 2012-05-04 11:27:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Adler 2012-05-04 21:01:35 PDT 
Where’s the COMPILE_ASSERT to catch us if we break this later?
Comment 8 Ryosuke Niwa 2012-05-04 22:06:22 PDT 
(In reply to comment #7)
> Where’s the COMPILE_ASSERT to catch us if we break this later?

It's in FillLayer.cpp. See the line 40 on http://trac.webkit.org/changeset/116129/trunk/Source/WebCore/rendering/style/FillLayer.cpp
Comment 9 Darin Adler 2012-05-05 17:09:35 PDT 
Ah, I see it now. Missed it the first time.