Bug 85633 – [CSSRegions] Add region styling support for color property

• Component: CSS
• Status: RESOLVED FIXED

[Mihnea Ovidenie]

Currently, region styling allows only background-color. Extend it by adding support for color.

[Mihnea Ovidenie]

Created attachment 140260 [details]
Patch

[WebKit Review Bot]

Comment on attachment 140260 [details]
Patch

Attachment 140260 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12531207

New failing tests:
fast/regions/render-region-custom-style-mark.html
fast/regions/region-style-color.html

[WebKit Review Bot]

Created attachment 140268 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Tony Chang]

This might be easier to review if you do the ref test conversion first as a separate patch.

[Gustavo Noronha (kov)]

Comment on attachment 140260 [details]
Patch

Attachment 140260 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12630327

[Mihnea Ovidenie]

Created attachment 140544 [details]
Patch 2

[WebKit Review Bot]

Comment on attachment 140544 [details]
Patch 2

Attachment 140544 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12647097

New failing tests:
fast/regions/render-region-custom-style-mark.html
fast/regions/region-style-color.html

[WebKit Review Bot]

Created attachment 140556 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Dave Hyatt]

Comment on attachment 140544 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=140544&action=review

> Source/WebCore/rendering/RenderInline.cpp:216
> +        || parentStyle->lineHeight() != style()->lineHeight()))
> +        || inRenderFlowThread();

I would like to see more precision here. You really mean "I'm in a render flow thread that has some custom styles." Let's not slow down the common case of no custom styling (which is as much as a 5-10% performance hit).

[Mihnea Ovidenie]

Created attachment 141434 [details]
Patch 3

[WebKit Review Bot]

Comment on attachment 141434 [details]
Patch 3

Attachment 141434 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12672364

New failing tests:
fast/regions/render-region-custom-style-mark.html
fast/regions/region-style-color.html

[WebKit Review Bot]

Created attachment 141442 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Dave Hyatt]

Comment on attachment 141434 [details]
Patch 3

r=me

[Mihnea Ovidenie]

Created attachment 143306 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 143306 [details]
Patch for landing

Clearing flags on attachment: 143306

Committed r117980: <http://trac.webkit.org/changeset/117980>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.