Bug 85614

Summary:

[Qt] Build fix when using libpng version > 1.2.

Product:

WebKit

Reporter:

Alexis Menard (darktears) <menard>

Component:

WebKit Qt

Assignee:

Alexis Menard (darktears) <menard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot, zoltan

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none
Patch	none

Alexis Menard (darktears)

Reported 2012-05-04 06:37:42 PDT

[Qt[D[3~d[D[D] Build fix for ver[D[D[D[D[D[D[D[Dwhen using libpng version > 1.2.

Attachments
Patch (1.16 KB, patch) 2012-05-04 06:39 PDT, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Patch (1.54 KB, patch) 2012-05-08 07:02 PDT, Zoltan Horvath	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexis Menard (darktears)

Comment 1 2012-05-04 06:39:40 PDT

Created attachment 140213 [details] Patch

Alexis Menard (darktears)

Comment 2 2012-05-04 06:39:59 PDT

(In reply to comment #1) > Created an attachment (id=140213) [details] > Patch Let see what EWS say.

Alexis Menard (darktears)

Comment 3 2012-05-04 06:50:11 PDT

Committed r116091: <http://trac.webkit.org/changeset/116091>

Zoltan Horvath

Comment 4 2012-05-08 07:01:32 PDT

This patch has been rollouted, it's safe to check it in, so we will avoid problems later.

Zoltan Horvath

Comment 5 2012-05-08 07:02:22 PDT

Created attachment 140712 [details] Patch

Rafael Brandao

Comment 6 2012-05-08 14:50:18 PDT

Comment on attachment 140712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140712&action=review I don't understand, the first patch was rolled out? If so, why this change won't get rolled out? I don't see much difference from the previous one. > Source/WebCore/ChangeLog:1 > +2012-05-08 Zoltan Horvath <zoltan@webkit.org> Maybe you should use Alexis name instead.

Eric Seidel (no email)

Comment 7 2012-05-08 15:06:25 PDT

Comment on attachment 140712 [details] Patch rs=me.

Eric Seidel (no email)

Comment 8 2012-05-08 15:07:24 PDT

Comment on attachment 140712 [details] Patch What's going on with this patch? It was rolled out? Is it ready to roll in again?

Zoltan Horvath

Comment 9 2012-05-09 01:17:45 PDT

(In reply to comment #8) > (From update of attachment 140712 [details]) > What's going on with this patch? It was rolled out? Is it ready to roll in again? It was a build fix for some systems, after landing the webcore imagedecoder patch from bug #80400 we rollouted it in one cup the patch and its buildfixes to decrease the mass-up. ...I didn't want to leave a build fix in the trunk for a rollouted revision. :) This way is more consistent I think, and it makes sense to push in. Thanks for the review.

WebKit Review Bot

Comment 10 2012-05-09 02:06:58 PDT

Comment on attachment 140712 [details] Patch Clearing flags on attachment: 140712 Committed r116507: <http://trac.webkit.org/changeset/116507>

WebKit Review Bot

Comment 11 2012-05-09 02:07:03 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.