Bug 85594 – [GTK][WPE] fast/dom/navigator-detached-no-crash.html fails on build bots

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Sudarsana Nagineni (babu)]

Created attachment 140183 [details]
actual results

fast/dom/navigator-detached-no-crash.html fails on build bots. So, moving to test_expectations now.

[Raphael Kubo da Costa (:rakuco)]

The current results differ even more:

--- /home/rakuco/dev/WebKit/WebKitBuild/Debug/layout-test-results/fast/dom/navigator-detached-no-crash-expected.txt
+++ /home/rakuco/dev/WebKit/WebKitBuild/Debug/layout-test-results/fast/dom/navigator-detached-no-crash-actual.txt
@@ -5,6 +5,7 @@
 navigator.appVersion is OK
 navigator.cookieEnabled is OK
 navigator.getStorageUpdates() is OK
+navigator.isProtocolHandlerRegistered() threw err TypeError: Not enough arguments
 navigator.javaEnabled() is OK
 navigator.language is OK
 navigator.mimeTypes is OK
@@ -13,14 +14,22 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
+navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
+navigator.unregisterProtocolHandler() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK
+navigator.vibrate() threw err TypeError: Not enough arguments
+navigator.webkitBattery is OK
+navigator.webkitConnection is OK
+navigator.webkitGetGamepads() is OK
+navigator.webkitStartActivity() threw err TypeError: Not enough arguments
 navigator.appCodeName is OK
 navigator.appName is OK
 navigator.appVersion is OK
 navigator.cookieEnabled is OK
 navigator.getStorageUpdates() is OK
+navigator.isProtocolHandlerRegistered() threw err TypeError: Not enough arguments
 navigator.javaEnabled() is OK
 navigator.language is OK
 navigator.mimeTypes is OK
@@ -29,7 +38,14 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
+navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
+navigator.unregisterProtocolHandler() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK
+navigator.vibrate() threw err TypeError: Not enough arguments
+navigator.webkitBattery is OK
+navigator.webkitConnection is OK
+navigator.webkitGetGamepads() is OK
+navigator.webkitStartActivity() threw err TypeError: Not enough arguments

[Raphael Kubo da Costa (:rakuco)]

There are two problems here: first, the results differ depending on the features enabled for each port (since we enable the protocol handling, battery etc stuff we get more entries). Secondly, some functions it tries to call actually require arguments, so the test also needs some love.

[Marcos Chavarría Teijeiro (irc: chavaone)]

This test is also failing on GTK port.

Updating TestExpectations on bug 143701.

The diff on GTK is the following:

--- /home/ch01/jhbuild/src/WebKit/WebKitBuild/Release/layout-test-results/fast/dom/navigator-detached-no-crash-expected.txt
+++ /home/ch01/jhbuild/src/WebKit/WebKitBuild/Release/layout-test-results/fast/dom/navigator-detached-no-crash-actual.txt
@@ -14,7 +14,6 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
-navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK
@@ -32,7 +31,6 @@
 navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
-navigator.registerProtocolHandler() threw err TypeError: Not enough arguments
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.

[Claudio Saavedra]

You missed this.

(In reply to Marcos Chavarría Teijeiro (irc: chavaone) from comment #3)
> This test is also failing on GTK port.
> 

It's also failing in WPE. Reopening.

[Claudio Saavedra]

Closing this as it turns out it's just a matter of updating the test expectations.